Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2895313002: Rename ScopedComPtr::swap() to ScopedComPtr::Swap() (Closed)

Created:
3 years, 7 months ago by robliao
Modified:
3 years, 7 months ago
Reviewers:
Lei Zhang, scottmg
CC:
chromium-reviews, grt+watch_chromium.org, danakj+watch_chromium.org, vmpstr+watch_chromium.org, wfh+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename ScopedComPtr::swap() to ScopedComPtr::Swap() This renames swap() to Swap() to harmonize with ComPtr::Swap(). BUG=638327 TBR=thestig@chromium.org Mechanical rename. Review-Url: https://codereview.chromium.org/2895313002 Cr-Commit-Position: refs/heads/master@{#473991} Committed: https://chromium.googlesource.com/chromium/src/+/02950edae45e711363532457ec564092ca1666f6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M base/win/scoped_comptr.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/google/google_update_win.cc View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 21 (15 generated)
robliao
scottmg: Please review this CL. Thanks!
3 years, 7 months ago (2017-05-22 18:00:41 UTC) #6
scottmg
lgtm
3 years, 7 months ago (2017-05-23 02:50:41 UTC) #7
robliao
TBR'ing thestig@ for chrome/... (Mechanical rename).
3 years, 7 months ago (2017-05-23 17:26:18 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2895313002/1
3 years, 7 months ago (2017-05-23 17:27:09 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/02950edae45e711363532457ec564092ca1666f6
3 years, 7 months ago (2017-05-23 18:29:23 UTC) #20
Lei Zhang
3 years, 7 months ago (2017-05-23 18:48:21 UTC) #21
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698