Unified the use of BufferToTextureTargetMap for all the Processes

content/browser/renderer_host/compositor_impl_android.cc

Index: content/browser/renderer_host/compositor_impl_android.cc
diff --git a/content/browser/renderer_host/compositor_impl_android.cc b/content/browser/renderer_host/compositor_impl_android.cc
index fff5edb377455b6abe81f8e9a36ca5d764c3e107..3f45c5efc737365c316c9e7e1ad1bd4dda948fee 100644
--- a/content/browser/renderer_host/compositor_impl_android.cc
+++ b/content/browser/renderer_host/compositor_impl_android.cc
@@ -31,6 +31,7 @@
 #include "cc/base/switches.h"
 #include "cc/input/input_handler.h"
 #include "cc/layers/layer.h"
+#include "cc/output/buffer_to_texture_target_map.h"
 #include "cc/output/compositor_frame.h"
 #include "cc/output/context_provider.h"
 #include "cc/output/output_surface.h"
@@ -529,6 +530,18 @@ void CompositorImpl::CreateLayerTreeHost() {
   settings.single_thread_proxy_scheduler = true;
 
   animation_host_ = cc::AnimationHost::CreateMainInstance();
+  for (int usage_idx = 0; usage_idx <= static_cast<int>(gfx::BufferUsage::LAST);

[boliu, 2017/06/07 23:14:48]

I think this code to generate a map from gpu::GetImageTextureTarget is now
repeated 3 times:
* ui/compositor
* render_process_host_impl where it's then turned into a string for the renderer
side
* here

can we unify these?

[sujith, 2017/06/08 10:40:30]

yes currently its been generated in 3 different places. 
All the place we are doing the same thing.
Previously it was generated at LayerTreeSettings, later it got 
changed https://codereview.chromium.org/2120713002

So what you suggest, generate it at LayerTreeSettings,
so that it will be available to all processes?

[boliu, 2017/06/08 17:00:00]

Add a method to content/browser/gpu/compositor_util.h:
cc::BufferToTextureTargetMap GetBufferToTextureTargetMap()

ui::CreateRendererSettings can be modified to take a ref of the map directly

+       ++usage_idx) {
+    gfx::BufferUsage usage = static_cast<gfx::BufferUsage>(usage_idx);
+    for (int format_idx = 0;
+         format_idx <= static_cast<int>(gfx::BufferFormat::LAST);
+         ++format_idx) {
+      gfx::BufferFormat format = static_cast<gfx::BufferFormat>(format_idx);
+      uint32_t target = gpu::GetImageTextureTarget(format, usage);
+      settings.buffer_to_texture_target_map[std::make_pair(usage, format)] =

[boliu, 2017/06/07 23:14:48]

you need a rebase I think, this setting moved into a separate ResourceSettings
recently

[sujith, 2017/06/08 10:40:30]

i have rebased the current patch based on the latest changes.

+          target;
+    }
+  }
 
   cc::LayerTreeHost::InitParams params;
   params.client = this;