Unified the use of BufferToTextureTargetMap for all the Processes

content/browser/renderer_host/compositor_impl_android.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/compositor_impl_android.h"
 
 #include <android/bitmap.h>
 #include <android/native_window_jni.h>
 #include <stdint.h>
 #include <unordered_set>
@@ skipping 13 matching lines @@
 #include "base/synchronization/lock.h"
 #include "base/sys_info.h"
 #include "base/threading/simple_thread.h"
 #include "base/threading/thread.h"
 #include "base/threading/thread_checker.h"
 #include "base/threading/thread_task_runner_handle.h"
 #include "cc/animation/animation_host.h"
 #include "cc/base/switches.h"
 #include "cc/input/input_handler.h"
 #include "cc/layers/layer.h"
+#include "cc/output/buffer_to_texture_target_map.h"
 #include "cc/output/compositor_frame.h"
 #include "cc/output/context_provider.h"
 #include "cc/output/output_surface.h"
 #include "cc/output/output_surface_client.h"
 #include "cc/output/output_surface_frame.h"
 #include "cc/output/texture_mailbox_deleter.h"
 #include "cc/output/vulkan_in_process_context_provider.h"
 #include "cc/raster/single_thread_task_graph_runner.h"
 #include "cc/resources/ui_resource_manager.h"
 #include "cc/surfaces/direct_compositor_frame_sink.h"
@@ skipping 478 matching lines @@
   settings.use_zero_copy = true;
 
   base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
   settings.initial_debug_state.SetRecordRenderingStats(
       command_line->HasSwitch(cc::switches::kEnableGpuBenchmarking));
   settings.initial_debug_state.show_fps_counter =
       command_line->HasSwitch(cc::switches::kUIShowFPSCounter);
   settings.single_thread_proxy_scheduler = true;
 
   animation_host_ = cc::AnimationHost::CreateMainInstance();
+  for (int usage_idx = 0; usage_idx <= static_cast<int>(gfx::BufferUsage::LAST);

[boliu, 2017/06/07 23:14:48]

I think this code to generate a map from gpu::GetImageTextureTarget is now
repeated 3 times:
* ui/compositor
* render_process_host_impl where it's then turned into a string for the renderer
side
* here

can we unify these?

[sujith, 2017/06/08 10:40:30]

yes currently its been generated in 3 different places. 
All the place we are doing the same thing.
Previously it was generated at LayerTreeSettings, later it got 
changed https://codereview.chromium.org/2120713002

So what you suggest, generate it at LayerTreeSettings,
so that it will be available to all processes?

[boliu, 2017/06/08 17:00:00]

Add a method to content/browser/gpu/compositor_util.h:
cc::BufferToTextureTargetMap GetBufferToTextureTargetMap()

ui::CreateRendererSettings can be modified to take a ref of the map directly

+       ++usage_idx) {
+    gfx::BufferUsage usage = static_cast<gfx::BufferUsage>(usage_idx);
+    for (int format_idx = 0;
+         format_idx <= static_cast<int>(gfx::BufferFormat::LAST);
+         ++format_idx) {
+      gfx::BufferFormat format = static_cast<gfx::BufferFormat>(format_idx);
+      uint32_t target = gpu::GetImageTextureTarget(format, usage);
+      settings.buffer_to_texture_target_map[std::make_pair(usage, format)] =

[boliu, 2017/06/07 23:14:48]

you need a rebase I think, this setting moved into a separate ResourceSettings
recently

[sujith, 2017/06/08 10:40:30]

i have rebased the current patch based on the latest changes.

+          target;
+    }
+  }
 
   cc::LayerTreeHost::InitParams params;
   params.client = this;
   params.task_graph_runner = &g_compositor_dependencies.Get().task_graph_runner;
   params.main_task_runner = base::ThreadTaskRunnerHandle::Get();
   params.settings = &settings;
   params.mutator_host = animation_host_.get();
   host_ = cc::LayerTreeHost::CreateSingleThreaded(this, &params);
   DCHECK(!host_->IsVisible());
   host_->SetRootLayer(root_window_->GetLayer());
@@ skipping 339 matching lines @@
   }
   GetSurfaceManager()->UnregisterFrameSinkHierarchy(frame_sink_id_,
                                                     frame_sink_id);
 }
 
 bool CompositorImpl::HavePendingReadbacks() {
   return !readback_layer_tree_->children().empty();
 }
 
 }  // namespace content