Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 2895263004: [subresource_filter] Add TRACE_EVENT probes for frame activation (Closed)

Created:
3 years, 7 months ago by Charlie Harrison
Modified:
3 years, 7 months ago
Reviewers:
shivanisha
CC:
chromium-reviews, darin-cc_chromium.org, jam, subresource-filter-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[subresource_filter] Add TRACE_EVENT probes for frame activation BUG=721512 Review-Url: https://codereview.chromium.org/2895263004 Cr-Commit-Position: refs/heads/master@{#474046} Committed: https://chromium.googlesource.com/chromium/src/+/3eff0ce486ad4cbb28bd6fb825688feb68903679

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -0 lines) Patch
M components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M components/subresource_filter/core/common/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/subresource_filter/core/common/activation_state.h View 2 chunks +10 lines, -0 lines 0 comments Download
A components/subresource_filter/core/common/activation_state.cc View 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Charlie Harrison
shivanisha: PTAL
3 years, 7 months ago (2017-05-22 18:09:19 UTC) #3
shivanisha
On 2017/05/22 at 18:09:19, csharrison wrote: > shivanisha: PTAL lgtm.
3 years, 7 months ago (2017-05-23 19:33:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2895263004/1
3 years, 7 months ago (2017-05-23 19:43:59 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 20:57:47 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3eff0ce486ad4cbb28bd6fb82568...

Powered by Google App Engine
This is Rietveld 408576698