Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Issue 2895253002: Reporting: Add missing #include <utility> (Closed)

Created:
3 years, 7 months ago by Julia Tuttle
Modified:
3 years, 7 months ago
Reviewers:
shivanisha
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reporting: Add missing #include <utility> What do you know, std::move doesn't come out of nowhere! BUG=704259 Review-Url: https://codereview.chromium.org/2895253002 Cr-Commit-Position: refs/heads/master@{#473655} Committed: https://chromium.googlesource.com/chromium/src/+/a35bbc87b95f73f8a5a704bc178763c389f29d1a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M net/reporting/reporting_cache.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/reporting/reporting_context.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/reporting/reporting_delivery_agent.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/reporting/reporting_garbage_collector.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/reporting/reporting_persister.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/reporting/reporting_report.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/reporting/reporting_service.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/reporting/reporting_uploader.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/reporting/reporting_uploader_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Julia Tuttle
PTAL, shivanisha.
3 years, 7 months ago (2017-05-22 17:58:15 UTC) #6
shivanisha
On 2017/05/22 at 17:58:15, juliatuttle wrote: > PTAL, shivanisha. LGTM
3 years, 7 months ago (2017-05-22 18:29:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2895253002/1
3 years, 7 months ago (2017-05-22 19:19:26 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-22 19:25:41 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a35bbc87b95f73f8a5a704bc1787...

Powered by Google App Engine
This is Rietveld 408576698