Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2895233004: [logdog/common/types] make StreamAddr implement flag.Value. (Closed)

Created:
3 years, 7 months ago by iannucci
Modified:
3 years, 7 months ago
Reviewers:
dnj
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -0 lines) Patch
M logdog/common/types/streamaddr.go View 2 chunks +13 lines, -0 lines 0 comments Download
M logdog/common/types/streamaddr_test.go View 2 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
iannucci
3 years, 7 months ago (2017-05-23 03:04:32 UTC) #1
dnj
lgtm
3 years, 7 months ago (2017-05-23 03:05:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2895233004/1
3 years, 7 months ago (2017-05-23 03:06:04 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 03:14:07 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/4363168106200329a674b3c6fd7a8bdb99ab0dd3

Powered by Google App Engine
This is Rietveld 408576698