Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 2895223002: Update the list of Google TLDs for Chrome M60 (Closed)

Created:
3 years, 7 months ago by msramek
Modified:
3 years, 7 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update the list of Google TLDs for Chrome M60 The new list was autogenerated as described in https://bugs.chromium.org/p/chromium/issues/detail?id=674712#c2. A number of TLDs were recently removed from our DNS configuration. BUG=674712 Review-Url: https://codereview.chromium.org/2895223002 Cr-Commit-Position: refs/heads/master@{#473643} Committed: https://chromium.googlesource.com/chromium/src/+/222e5e899928269ee42e1215b21b33b656522027

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -33 lines) Patch
M components/google/core/browser/google_tld_list.h View 1 chunk +28 lines, -33 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
msramek
Hi Peter, Please have a look! It took 3 milestones to actually get a change ...
3 years, 7 months ago (2017-05-22 14:34:03 UTC) #8
Peter Kasting
LGTM
3 years, 7 months ago (2017-05-22 18:36:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2895223002/1
3 years, 7 months ago (2017-05-22 18:57:00 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-22 19:04:30 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/222e5e899928269ee42e1215b21b...

Powered by Google App Engine
This is Rietveld 408576698