Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 2895213004: Add felt@ to Safe Browsing OWNERS file for blocking page changes (Closed)

Created:
3 years, 7 months ago by felt
Modified:
3 years, 7 months ago
Reviewers:
Nathan Parker
CC:
chromium-reviews, grt+watch_chromium.org, vakh+watch_chromium.org, timvolodine
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add felt@ to Safe Browsing OWNERS file for blocking page changes BUG= R=nparker@chromium.org Review-Url: https://codereview.chromium.org/2895213004 Cr-Commit-Position: refs/heads/master@{#473926} Committed: https://chromium.googlesource.com/chromium/src/+/d2eb8579c1d9977bb51c2041eecb431a0b5fabdc

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove comment from the OWNERS file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/browser/safe_browsing/OWNERS View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
felt
nparker, ptal?
3 years, 7 months ago (2017-05-23 04:28:08 UTC) #1
Nathan Parker
lgtm https://codereview.chromium.org/2895213004/diff/1/chrome/browser/safe_browsing/OWNERS File chrome/browser/safe_browsing/OWNERS (right): https://codereview.chromium.org/2895213004/diff/1/chrome/browser/safe_browsing/OWNERS#newcode4 chrome/browser/safe_browsing/OWNERS:4: # For download-protection- and reporting-related changes: Can you ...
3 years, 7 months ago (2017-05-23 15:48:28 UTC) #3
felt
https://codereview.chromium.org/2895213004/diff/1/chrome/browser/safe_browsing/OWNERS File chrome/browser/safe_browsing/OWNERS (right): https://codereview.chromium.org/2895213004/diff/1/chrome/browser/safe_browsing/OWNERS#newcode4 chrome/browser/safe_browsing/OWNERS:4: # For download-protection- and reporting-related changes: On 2017/05/23 15:48:27, ...
3 years, 7 months ago (2017-05-23 15:59:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2895213004/20001
3 years, 7 months ago (2017-05-23 16:00:18 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 16:15:16 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d2eb8579c1d9977bb51c2041eecb...

Powered by Google App Engine
This is Rietveld 408576698