Cleanup traversing in LayoutSelection.cpp::CollectSelectedMap()

Cleanup traversing in LayoutSelection.cpp::CollectSelectedMap()

Since |selection_start| is always before |selection_end|(L322),
 we don't need to switch back traversing.

Patch[1] introduced the backward traversal to support CSS Region.
Since, Blink doesn't support CSS Region, we can remove it safely.

[1] https://chromiumcodereview.appspot.com/23674007 [CSSRegions] Not possible to
clear the selection when mixing content from different FlowThreads 

BUG=708453
Review-Url: https://codereview.chromium.org/2895193002
Cr-Commit-Position: refs/heads/master@{#473872}
Committed: https://chromium.googlesource.com/chromium/src/+/353a96e9ef4fe92c8808aac4acec49b2a7527109

[yoichio, 2017-05-22 08:27:56]

The CQ bit was checked by yoichio@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 08:28:20]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 11:15:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 11:15:48]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yoichio, 2017-05-23 01:40:59]

Description was changed from

==========
refactor traversing in setselection

BUG=708453
==========

to

==========
Cleanup traversing in LayoutSelection.cpp::CollectSelectedMap()

Since |selection_start| is always before |selection_end|(L322),
 we don't need to switch back traversing.

BUG=708453
==========

[yoichio, 2017-05-23 01:40:59]

yoichio@chromium.org changed reviewers:
+ yosin@chromium.org

[yoichio, 2017-05-23 05:40:34]

PTAL

[yosin_UTC9, 2017-05-23 09:01:36]

lgtm w/ small nit
and please update description to provide an evidence about
safeness of removing GetNextOrPrevLayoutObjectBasedDiretion().

https://codereview.chromium.org/2895193002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/LayoutSelection.cpp (left):

https://codereview.chromium.org/2895193002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/LayoutSelection.cpp:105: // the "start"
position is below the "end" one.
It seems patch[1] introduce backward traversal to support CSS Region.
Since, Blink doesn't support CSS Region, we can remove safely.

Please add this info into description for future reference.

[1] https://chromiumcodereview.appspot.com/23674007 [CSSRegions] Not possible to
clear the selection when mixing content from different FlowThreads

https://codereview.chromium.org/2895193002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/LayoutSelection.cpp (right):

https://codereview.chromium.org/2895193002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/LayoutSelection.cpp:322: DCHECK(start_pos
<= end_pos);
nit: DCHECK_LE(start_pos, end_pos)

[yoichio, 2017-05-23 09:11:02]

Description was changed from

==========
Cleanup traversing in LayoutSelection.cpp::CollectSelectedMap()

Since |selection_start| is always before |selection_end|(L322),
 we don't need to switch back traversing.

BUG=708453
==========

to

==========
Cleanup traversing in LayoutSelection.cpp::CollectSelectedMap()

Since |selection_start| is always before |selection_end|(L322),
 we don't need to switch back traversing.

Patch[1] introduced the backward traversal to support CSS Region.
Since, Blink doesn't support CSS Region, we can remove it safely.

[1] https://chromiumcodereview.appspot.com/23674007 [CSSRegions] Not possible to
clear the selection when mixing content from different FlowThreads 

BUG=708453
==========

[yoichio, 2017-05-23 09:12:52]

The CQ bit was checked by yoichio@chromium.org

[yoichio, 2017-05-23 09:12:53]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/2895193002/#ps20001
(title: "nit")

[commit-bot: I haz the power, 2017-05-23 09:13:10]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 13:04:05]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495530772588250,
"parent_rev": "9c0a1e4d561f51b8aa0861a952b0612934f9bbe6", "commit_rev":
"353a96e9ef4fe92c8808aac4acec49b2a7527109"}

[commit-bot: I haz the power, 2017-05-23 13:04:12]

Description was changed from

==========
Cleanup traversing in LayoutSelection.cpp::CollectSelectedMap()

Since |selection_start| is always before |selection_end|(L322),
 we don't need to switch back traversing.

Patch[1] introduced the backward traversal to support CSS Region.
Since, Blink doesn't support CSS Region, we can remove it safely.

[1] https://chromiumcodereview.appspot.com/23674007 [CSSRegions] Not possible to
clear the selection when mixing content from different FlowThreads 

BUG=708453
==========

to

==========
Cleanup traversing in LayoutSelection.cpp::CollectSelectedMap()

Since |selection_start| is always before |selection_end|(L322),
 we don't need to switch back traversing.

Patch[1] introduced the backward traversal to support CSS Region.
Since, Blink doesn't support CSS Region, we can remove it safely.

[1] https://chromiumcodereview.appspot.com/23674007 [CSSRegions] Not possible to
clear the selection when mixing content from different FlowThreads 

BUG=708453

Review-Url: https://codereview.chromium.org/2895193002
Cr-Commit-Position: refs/heads/master@{#473872}
Committed:
https://chromium.googlesource.com/chromium/src/+/353a96e9ef4fe92c8808aac4acec...
==========

[commit-bot: I haz the power, 2017-05-23 13:04:14]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/353a96e9ef4fe92c8808aac4acec...