Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 2895173002: Network traffic annotation added to browser unittests. (Closed)

Created:
3 years, 7 months ago by Ramin Halavati
Modified:
3 years, 7 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, tburkard+watch_chromium.org, gavinp+prer_chromium.org, cbentzel+watch_chromium.org, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Network traffic annotation added to browser unittests. Network traffic annotation is added to network requests of: chrome/browser/net/proxy_browsertest.cc chrome/browser/predictors/resource_prefetch_predictor_unittest.cc chrome/browser/prerender/prerender_resource_throttle_unittest.cc chrome/browser/ui/views/ssl_client_certificate_selector_browsertest.cc BUG=656607 Review-Url: https://codereview.chromium.org/2895173002 Cr-Commit-Position: refs/heads/master@{#473740} Committed: https://chromium.googlesource.com/chromium/src/+/8aa3fbb79e39ccdf515719286db9b5cca258bc1b

Patch Set 1 #

Patch Set 2 : One more file added. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M chrome/browser/net/proxy_browsertest.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/predictors/resource_prefetch_predictor_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/prerender/prerender_resource_throttle_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/ssl_client_certificate_selector_browsertest.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 15 (11 generated)
Ramin Halavati
Hi, I've added more test network traffic annotation tags to browser unittests, please review.
3 years, 7 months ago (2017-05-22 08:35:14 UTC) #9
Lei Zhang
lgtm
3 years, 7 months ago (2017-05-22 23:21:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2895173002/20001
3 years, 7 months ago (2017-05-22 23:21:57 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-05-22 23:27:34 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8aa3fbb79e39ccdf515719286db9...

Powered by Google App Engine
This is Rietveld 408576698