Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 2895163002: [builtins] Add --print-builtin-size flag (Closed)

Created:
3 years, 7 months ago by jgruber
Modified:
3 years, 6 months ago
CC:
Benedikt Meurer, Michael Hablich, v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Add --print-builtin-size flag Passing --print-builtin-size will print the size of all builtins on isolate creation. BUG=v8:5737 Review-Url: https://codereview.chromium.org/2895163002 Cr-Commit-Position: refs/heads/master@{#45605} Committed: https://chromium.googlesource.com/v8/v8/+/0930a9243a62c5a059bf55217efb5dec0f71a78a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M src/flag-definitions.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/isolate.cc View 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
jgruber
Could be useful from time to time.. WDYT?
3 years, 7 months ago (2017-05-22 07:37:53 UTC) #4
Camillo Bruni
lgtm
3 years, 7 months ago (2017-05-24 08:14:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2895163002/1
3 years, 6 months ago (2017-05-30 13:31:02 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-05-30 14:14:38 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/0930a9243a62c5a059bf55217efb5dec0f7...

Powered by Google App Engine
This is Rietveld 408576698