Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 2895153004: Relimit Skia to ES2 to address performance regression (Closed)

Created:
3 years, 7 months ago by bsalomon
Modified:
3 years, 7 months ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, piman+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Relimit Skia to ES2 to address performance regression BUG=719572 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2895153004 Cr-Commit-Position: refs/heads/master@{#473666} Committed: https://chromium.googlesource.com/chromium/src/+/8d52fb787ae3f370ba1bf7be4b15ae01287879ac

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M gpu/skia_bindings/gl_bindings_skia_cmd_buffer.cc View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 15 (11 generated)
bsalomon
Mo, turns out you were right to caution against performance regressions. After my change we ...
3 years, 7 months ago (2017-05-22 19:42:27 UTC) #8
Zhenyao Mo
lgtm Hope we can get to the bottom of this perf issue and move on ...
3 years, 7 months ago (2017-05-22 19:44:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2895153004/1
3 years, 7 months ago (2017-05-22 19:53:09 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-22 19:58:56 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8d52fb787ae3f370ba1bf7be4b15...

Powered by Google App Engine
This is Rietveld 408576698