Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2895153002:
Generate getters/setters for orphans and widows. (Closed)
|
Created:
3 years, 7 months ago by shend Modified:
3 years, 7 months ago Reviewers:
meade_UTC10 CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionGenerate getters/setters for orphans and widows.
Currently, the orphans and widows property are 'storage_only' fields, so
they have no generated public getters/setters. This patch changes them to
'primitive' fields so that their getters/setters can be generated as well.
Diff of generated files:
https://gist.github.com/darrnshn/f98f90a4ed74459ade6a99d568ae0b6c/revisions
BUG=628043
Review-Url: https://codereview.chromium.org/2895153002
Cr-Commit-Position: refs/heads/master@{#474591}
Committed: https://chromium.googlesource.com/chromium/src/+/0ae95b2247726145ecab341fd01c12b4bb2dfb04
Patch Set 1 #Patch Set 2 : Rebase #
Messages
Total messages: 22 (18 generated)
Description was changed from ========== Generate getters/setters for orphans. Currently, the orphans property is a 'storage_only' field, so it has no generated public getters/setters. This patch changes it to an 'primitive' field so that their getters/setters can be generated as well. BUG=628043 ========== to ========== Generate getters/setters for orphans. Currently, the orphans property is a 'storage_only' field, so it has no generated public getters/setters. This patch changes it to an 'primitive' field so that their getters/setters can be generated as well. Diff of generated files: https://gist.github.com/darrnshn/f98f90a4ed74459ade6a99d568ae0b6c/revisions BUG=628043 ==========
shend@chromium.org changed reviewers: + meade@chromium.org
Hi Eddy, PTAL
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Description was changed from ========== Generate getters/setters for orphans. Currently, the orphans property is a 'storage_only' field, so it has no generated public getters/setters. This patch changes it to an 'primitive' field so that their getters/setters can be generated as well. Diff of generated files: https://gist.github.com/darrnshn/f98f90a4ed74459ade6a99d568ae0b6c/revisions BUG=628043 ========== to ========== Generate getters/setters for orphans and widows. Currently, the orphans and widows property are 'storage_only' fields, so they have no generated public getters/setters. This patch changes them to 'primitive' fields so that their getters/setters can be generated as well. Diff of generated files: https://gist.github.com/darrnshn/f98f90a4ed74459ade6a99d568ae0b6c/revisions BUG=628043 ==========
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by shend@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495695155001590,
"parent_rev": "fc1fe7bf2508b1301933004e0f4e44bf55b3032a", "commit_rev":
"0ae95b2247726145ecab341fd01c12b4bb2dfb04"}
Message was sent while issue was closed.
Description was changed from ========== Generate getters/setters for orphans and widows. Currently, the orphans and widows property are 'storage_only' fields, so they have no generated public getters/setters. This patch changes them to 'primitive' fields so that their getters/setters can be generated as well. Diff of generated files: https://gist.github.com/darrnshn/f98f90a4ed74459ade6a99d568ae0b6c/revisions BUG=628043 ========== to ========== Generate getters/setters for orphans and widows. Currently, the orphans and widows property are 'storage_only' fields, so they have no generated public getters/setters. This patch changes them to 'primitive' fields so that their getters/setters can be generated as well. Diff of generated files: https://gist.github.com/darrnshn/f98f90a4ed74459ade6a99d568ae0b6c/revisions BUG=628043 Review-Url: https://codereview.chromium.org/2895153002 Cr-Commit-Position: refs/heads/master@{#474591} Committed: https://chromium.googlesource.com/chromium/src/+/0ae95b2247726145ecab341fd01c... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/0ae95b2247726145ecab341fd01c... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
