Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2895133002:
Generate getters/setters for Highlight. (Closed)
|
Created:
3 years, 7 months ago by shend Modified:
3 years, 6 months ago Reviewers:
meade_UTC10 CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionGenerate getters/setters for Highlight.
Currently, the Highlight property is a 'storage_only' field, so
it has no generated public getters/setters. This patch changes it to an
'external' field so that their getters/setters can be generated as well.
Diff of generated files:
https://gist.github.com/darrnshn/6568c64622c1f975f9c2124712625460/revisions
BUG=628043
Review-Url: https://codereview.chromium.org/2895133002
Cr-Commit-Position: refs/heads/master@{#475275}
Committed: https://chromium.googlesource.com/chromium/src/+/bc9f245e0196fd1597d504f0e6edcd1e868a45e3
Patch Set 1 #Patch Set 2 : Rebase #Patch Set 3 : Rebase #Patch Set 4 : Rebase #
Messages
Total messages: 27 (21 generated)
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)
Description was changed from ========== Generate getters/setters for Highlight. Currently, the Highlight property is a 'storage_only' field, so it has no generated public getters/setters. This patch changes it to an 'external' field so that their getters/setters can be generated as well. BUG=628043 ========== to ========== Generate getters/setters for Highlight. Currently, the Highlight property is a 'storage_only' field, so it has no generated public getters/setters. This patch changes it to an 'external' field so that their getters/setters can be generated as well. Diff of generated files: https://gist.github.com/darrnshn/6568c64622c1f975f9c2124712625460/revisions BUG=628043 ==========
shend@chromium.org changed reviewers: + meade@chromium.org
Hi Eddy, PTAL
lgtm
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by shend@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from meade@chromium.org Link to the patchset: https://codereview.chromium.org/2895133002/#ps40001 (title: "Rebase")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by shend@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from meade@chromium.org Link to the patchset: https://codereview.chromium.org/2895133002/#ps60001 (title: "Rebase")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1496023246117620,
"parent_rev": "49753ec593d5cd5e2faab80397058b15bdfb2089", "commit_rev":
"bc9f245e0196fd1597d504f0e6edcd1e868a45e3"}
Message was sent while issue was closed.
Description was changed from ========== Generate getters/setters for Highlight. Currently, the Highlight property is a 'storage_only' field, so it has no generated public getters/setters. This patch changes it to an 'external' field so that their getters/setters can be generated as well. Diff of generated files: https://gist.github.com/darrnshn/6568c64622c1f975f9c2124712625460/revisions BUG=628043 ========== to ========== Generate getters/setters for Highlight. Currently, the Highlight property is a 'storage_only' field, so it has no generated public getters/setters. This patch changes it to an 'external' field so that their getters/setters can be generated as well. Diff of generated files: https://gist.github.com/darrnshn/6568c64622c1f975f9c2124712625460/revisions BUG=628043 Review-Url: https://codereview.chromium.org/2895133002 Cr-Commit-Position: refs/heads/master@{#475275} Committed: https://chromium.googlesource.com/chromium/src/+/bc9f245e0196fd1597d504f0e6ed... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/bc9f245e0196fd1597d504f0e6ed... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
