memory-infra: rename service folder to memory_instrumentation

memory-infra: rename service folder to memory_instrumentation

This is a non-functional refactoring that renamed the memory
instrumentation code within //services/resource_coordinator. Due to
projects/people reshuffling the code ended up being moved
into memory/coordinator that doesn't reflect what the code
inside does (it deals only with instrumentation). Furthermore it is extremely
confusing, as there is a "memory coordinator" project happening in chrome,
which is completely orthogonal with this.

The renames consists of:
- Move the code in //services/resource_coordinator
  from memory/coordinator/ to memory_instrumentation
- Ditto for the public library code in
  //services/resource_coordinator/public/cpp and
  //services/resource_coordinator/public/interfaces
- Rename the class in the client library that handshakes with the
  Coordinator in the service and deals with in-process dumps
  from "ProcessLocalDumpManager" to "ClientProcess"
   

On top of this, this CL does two minor cleanups in the memory-infra codebase:
- Using new THREAD_CHECKER macro instead of the ThreadChecker class
   (reduces size on non-debug builds).
- Sorts out the ...ForTesting() pattern in MemoryDumpManager, removing the
   need of friend-ing a class outside of its folder.

BUG=703184
TBR=jochen@chromium.org

Review-Url: https://codereview.chromium.org/2895083004
Cr-Commit-Position: refs/heads/master@{#473568}
Committed: https://chromium.googlesource.com/chromium/src/+/aca468f8904f44043315a0366c645d594f765a06

[Primiano Tucci (use gerrit), 2017-05-22 09:56:53]

The CQ bit was checked by primiano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 09:57:14]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Primiano Tucci (use gerrit), 2017-05-22 09:59:02]

Description was changed from

==========
memory instrumentation service: rename folder

This is a non-functional refactoring aimed at moving the
memory-instrumentation
code into its own folder. Due to projects reshuffling the code ended up
being moved to a folder (memory/coordinator) that doesn't reflect what
the code inside does (it deals only with instrumentation.

BUG=
==========

to

==========
memory instrumentation service: rename folder

This is a non-functional refactoring aimed at moving the memory
instrumentation code into its own folder. Due to projects/people
reshuffling the code ended up being moved into memory/coordinator
that doesn't reflect what the code inside does (it deals only with
instrumentation). Furthermore it is extremely confusing, as there is
a "memory coordinator" project happening in chrome, which is completely
orthogonal with this.


BUG=
==========

[commit-bot: I haz the power, 2017-05-22 09:59:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 09:59:58]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Primiano Tucci (use gerrit), 2017-05-22 10:06:11]

Description was changed from

==========
memory instrumentation service: rename folder

This is a non-functional refactoring aimed at moving the memory
instrumentation code into its own folder. Due to projects/people
reshuffling the code ended up being moved into memory/coordinator
that doesn't reflect what the code inside does (it deals only with
instrumentation). Furthermore it is extremely confusing, as there is
a "memory coordinator" project happening in chrome, which is completely
orthogonal with this.


BUG=
==========

to

==========
memory instrumentation service: rename folder

This is a non-functional refactoring aimed at moving the memory
instrumentation code into its own folder. Due to projects/people
reshuffling the code ended up being moved into memory/coordinator
that doesn't reflect what the code inside does (it deals only with
instrumentation). Furthermore it is extremely confusing, as there is
a "memory coordinator" project happening in chrome, which is completely
orthogonal with this.

The renames consists of:
- Move the code in //services/resource_coordinator
  from memory/coordinator/ to memory_instrumentation
- Ditto for the public library code in
  //services/resource_coordinator/public/cpp and
  //services/resource_coordinator/public/interfaces
- Rename the class in the client library that handshakes with the
  Coordinator in the service and deals with in-process dumps
  from "ProcessLocalDumpManager" to "ClientProcess"
   

On top of this, this CL does minor cleanups found along the way (using the
new THREAD_CHECKER macro, sorting out ...ForTesting() patterns).

BUG=703184
==========

[Primiano Tucci (use gerrit), 2017-05-22 10:12:38]

The CQ bit was checked by primiano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 10:13:04]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Primiano Tucci (use gerrit), 2017-05-22 10:21:14]

Description was changed from

==========
memory instrumentation service: rename folder

This is a non-functional refactoring aimed at moving the memory
instrumentation code into its own folder. Due to projects/people
reshuffling the code ended up being moved into memory/coordinator
that doesn't reflect what the code inside does (it deals only with
instrumentation). Furthermore it is extremely confusing, as there is
a "memory coordinator" project happening in chrome, which is completely
orthogonal with this.

The renames consists of:
- Move the code in //services/resource_coordinator
  from memory/coordinator/ to memory_instrumentation
- Ditto for the public library code in
  //services/resource_coordinator/public/cpp and
  //services/resource_coordinator/public/interfaces
- Rename the class in the client library that handshakes with the
  Coordinator in the service and deals with in-process dumps
  from "ProcessLocalDumpManager" to "ClientProcess"
   

On top of this, this CL does minor cleanups found along the way (using the
new THREAD_CHECKER macro, sorting out ...ForTesting() patterns).

BUG=703184
==========

to

==========
memory-infra: rename service folder to memory_instrumentation

This is a non-functional refactoring that renamed the memory
instrumentation code within //services/resource_coordinator. Due to
projects/people reshuffling the code ended up being moved
into memory/coordinator that doesn't reflect what the code
inside does (it deals only with instrumentation). Furthermore it is extremely
confusing, as there is a "memory coordinator" project happening in chrome,
which is completely orthogonal with this.

The renames consists of:
- Move the code in //services/resource_coordinator
  from memory/coordinator/ to memory_instrumentation
- Ditto for the public library code in
  //services/resource_coordinator/public/cpp and
  //services/resource_coordinator/public/interfaces
- Rename the class in the client library that handshakes with the
  Coordinator in the service and deals with in-process dumps
  from "ProcessLocalDumpManager" to "ClientProcess"
   

On top of this, this CL does two minor cleanups in the memory-infra codebase:
- Using new THREAD_CHECKER macro instead of the ThreadChecker class
   (reduces size on non-debug builds).
- Sorts out the ...ForTesting() pattern in MemoryDumpManager, removing the
   need of friend-ing a class outside of its folder.

BUG=703184
==========

[Primiano Tucci (use gerrit), 2017-05-22 10:27:50]

primiano@chromium.org changed reviewers:
+ hjd@chromium.org

[Primiano Tucci (use gerrit), 2017-05-22 10:27:51]

Look, this week's BA in-flight entertainment was about the
memory-instrumentation service.

+hjd PTAL
+others people working in the space FYI

[hjd, 2017-05-22 10:46:29]

lgtm % nits

https://codereview.chromium.org/2895083004/diff/1/base/trace_event/memory_dum...
File base/trace_event/memory_dump_manager.cc (right):

https://codereview.chromium.org/2895083004/diff/1/base/trace_event/memory_dum...
base/trace_event/memory_dump_manager.cc:162: std::unique_ptr<MemoryDumpManager>
instance(new MemoryDumpManager());
nit: MakeUnique?

https://codereview.chromium.org/2895083004/diff/1/services/resource_coordinat...
File services/resource_coordinator/memory_instrumentation/coordinator_impl.cc
(right):

https://codereview.chromium.org/2895083004/diff/1/services/resource_coordinat...
services/resource_coordinator/memory_instrumentation/coordinator_impl.cc:156: //
Check if we are waiting for an ack from this process-local manager.
nit: s/process-local manager/client process/

https://codereview.chromium.org/2895083004/diff/1/services/resource_coordinat...
services/resource_coordinator/memory_instrumentation/coordinator_impl.cc:175: //
will be treated like other process-local managers.
nit: s/process-local manager/client process/

https://codereview.chromium.org/2895083004/diff/1/services/resource_coordinat...
services/resource_coordinator/memory_instrumentation/coordinator_impl.cc:185: //
Run the callback in case there are no process-local managers.
nit: s/process-local manager/client process/

https://codereview.chromium.org/2895083004/diff/1/services/resource_coordinat...
File
services/resource_coordinator/public/interfaces/memory_instrumentation/OWNERS
(right):

https://codereview.chromium.org/2895083004/diff/1/services/resource_coordinat...
services/resource_coordinator/public/interfaces/memory_instrumentation/OWNERS:1:
per-file *.mojom=set noparent
I think Rietveld is confused? This file hasn't changed.

https://codereview.chromium.org/2895083004/diff/1/services/resource_coordinat...
File
services/resource_coordinator/public/interfaces/memory_instrumentation/constants.mojom
(right):

https://codereview.chromium.org/2895083004/diff/1/services/resource_coordinat...
services/resource_coordinator/public/interfaces/memory_instrumentation/constants.mojom:1:
// Copyright 2017 The Chromium Authors. All rights reserved.
I think Rietveld is confused? This file hasn't changed.

[commit-bot: I haz the power, 2017-05-22 11:42:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 11:42:07]

Dry run: This issue passed the CQ dry run.

[Primiano Tucci (use gerrit), 2017-05-22 11:42:31]

The CQ bit was checked by primiano@chromium.org to run a CQ dry run

[Primiano Tucci (use gerrit), 2017-05-22 11:42:37]

https://codereview.chromium.org/2895083004/diff/1/base/trace_event/memory_dum...
File base/trace_event/memory_dump_manager.cc (right):

https://codereview.chromium.org/2895083004/diff/1/base/trace_event/memory_dum...
base/trace_event/memory_dump_manager.cc:162: std::unique_ptr<MemoryDumpManager>
instance(new MemoryDumpManager());
On 2017/05/22 10:46:29, hjd wrote:
> nit: MakeUnique?

ah good point, I tried, but this can't be: the ctor is private due to Singleton
and MakeUnique can't use it (as technically MakeUnique is outside of this
class). so I think this should stay as it is.

https://codereview.chromium.org/2895083004/diff/1/services/resource_coordinat...
File services/resource_coordinator/memory_instrumentation/coordinator_impl.cc
(right):

https://codereview.chromium.org/2895083004/diff/1/services/resource_coordinat...
services/resource_coordinator/memory_instrumentation/coordinator_impl.cc:156: //
Check if we are waiting for an ack from this process-local manager.
On 2017/05/22 10:46:29, hjd wrote:
> nit: s/process-local manager/client process/

Done.

https://codereview.chromium.org/2895083004/diff/1/services/resource_coordinat...
services/resource_coordinator/memory_instrumentation/coordinator_impl.cc:175: //
will be treated like other process-local managers.
On 2017/05/22 10:46:29, hjd wrote:
> nit: s/process-local manager/client process/

Done.

https://codereview.chromium.org/2895083004/diff/1/services/resource_coordinat...
services/resource_coordinator/memory_instrumentation/coordinator_impl.cc:185: //
Run the callback in case there are no process-local managers.
On 2017/05/22 10:46:29, hjd wrote:
> nit: s/process-local manager/client process/

Done.

https://codereview.chromium.org/2895083004/diff/1/services/resource_coordinat...
File
services/resource_coordinator/public/interfaces/memory_instrumentation/OWNERS
(right):

https://codereview.chromium.org/2895083004/diff/1/services/resource_coordinat...
services/resource_coordinator/public/interfaces/memory_instrumentation/OWNERS:1:
per-file *.mojom=set noparent
On 2017/05/22 10:46:29, hjd wrote:
> I think Rietveld is confused? This file hasn't changed.

right this is just saying that this file has been renamed with no content
changes

https://codereview.chromium.org/2895083004/diff/1/services/resource_coordinat...
File
services/resource_coordinator/public/interfaces/memory_instrumentation/constants.mojom
(right):

https://codereview.chromium.org/2895083004/diff/1/services/resource_coordinat...
services/resource_coordinator/public/interfaces/memory_instrumentation/constants.mojom:1:
// Copyright 2017 The Chromium Authors. All rights reserved.
On 2017/05/22 10:46:29, hjd wrote:
> I think Rietveld is confused? This file hasn't changed.

only the path has changed.

[commit-bot: I haz the power, 2017-05-22 11:42:46]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Primiano Tucci (use gerrit), 2017-05-22 11:43:51]

primiano@chromium.org changed reviewers:
+ jochen@chromium.org

[Primiano Tucci (use gerrit), 2017-05-22 11:43:52]

+jochen for 15 lines in //content, and //chrome. I am just renaming things.

[commit-bot: I haz the power, 2017-05-22 13:13:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 13:13:23]

Dry run: This issue passed the CQ dry run.

[Primiano Tucci (use gerrit), 2017-05-22 13:24:03]

Description was changed from

==========
memory-infra: rename service folder to memory_instrumentation

This is a non-functional refactoring that renamed the memory
instrumentation code within //services/resource_coordinator. Due to
projects/people reshuffling the code ended up being moved
into memory/coordinator that doesn't reflect what the code
inside does (it deals only with instrumentation). Furthermore it is extremely
confusing, as there is a "memory coordinator" project happening in chrome,
which is completely orthogonal with this.

The renames consists of:
- Move the code in //services/resource_coordinator
  from memory/coordinator/ to memory_instrumentation
- Ditto for the public library code in
  //services/resource_coordinator/public/cpp and
  //services/resource_coordinator/public/interfaces
- Rename the class in the client library that handshakes with the
  Coordinator in the service and deals with in-process dumps
  from "ProcessLocalDumpManager" to "ClientProcess"
   

On top of this, this CL does two minor cleanups in the memory-infra codebase:
- Using new THREAD_CHECKER macro instead of the ThreadChecker class
   (reduces size on non-debug builds).
- Sorts out the ...ForTesting() pattern in MemoryDumpManager, removing the
   need of friend-ing a class outside of its folder.

BUG=703184
==========

to

==========
memory-infra: rename service folder to memory_instrumentation

This is a non-functional refactoring that renamed the memory
instrumentation code within //services/resource_coordinator. Due to
projects/people reshuffling the code ended up being moved
into memory/coordinator that doesn't reflect what the code
inside does (it deals only with instrumentation). Furthermore it is extremely
confusing, as there is a "memory coordinator" project happening in chrome,
which is completely orthogonal with this.

The renames consists of:
- Move the code in //services/resource_coordinator
  from memory/coordinator/ to memory_instrumentation
- Ditto for the public library code in
  //services/resource_coordinator/public/cpp and
  //services/resource_coordinator/public/interfaces
- Rename the class in the client library that handshakes with the
  Coordinator in the service and deals with in-process dumps
  from "ProcessLocalDumpManager" to "ClientProcess"
   

On top of this, this CL does two minor cleanups in the memory-infra codebase:
- Using new THREAD_CHECKER macro instead of the ThreadChecker class
   (reduces size on non-debug builds).
- Sorts out the ...ForTesting() pattern in MemoryDumpManager, removing the
   need of friend-ing a class outside of its folder.

BUG=703184
TBR=jochen@chromium.org
==========

[Primiano Tucci (use gerrit), 2017-05-22 13:25:51]

On 2017/05/22 11:43:52, Primiano (slow - traveling) wrote:
> +jochen for 15 lines in //content, and //chrome. I am just renaming things.

TBRing jochen@ as those lines in  //content, and //chrome are mechanical renames

[Primiano Tucci (use gerrit), 2017-05-22 13:25:57]

The CQ bit was checked by primiano@chromium.org

[Primiano Tucci (use gerrit), 2017-05-22 13:25:58]

The patchset sent to the CQ was uploaded after l-g-t-m from hjd@chromium.org
Link to the patchset: https://codereview.chromium.org/2895083004/#ps40001
(title: "comments")

[commit-bot: I haz the power, 2017-05-22 13:26:16]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 13:30:36]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495459557674420,
"parent_rev": "99c274ae8e7d366261dcfb89e0b98e733fb9d5f4", "commit_rev":
"aca468f8904f44043315a0366c645d594f765a06"}

[commit-bot: I haz the power, 2017-05-22 13:30:49]

Description was changed from

==========
memory-infra: rename service folder to memory_instrumentation

This is a non-functional refactoring that renamed the memory
instrumentation code within //services/resource_coordinator. Due to
projects/people reshuffling the code ended up being moved
into memory/coordinator that doesn't reflect what the code
inside does (it deals only with instrumentation). Furthermore it is extremely
confusing, as there is a "memory coordinator" project happening in chrome,
which is completely orthogonal with this.

The renames consists of:
- Move the code in //services/resource_coordinator
  from memory/coordinator/ to memory_instrumentation
- Ditto for the public library code in
  //services/resource_coordinator/public/cpp and
  //services/resource_coordinator/public/interfaces
- Rename the class in the client library that handshakes with the
  Coordinator in the service and deals with in-process dumps
  from "ProcessLocalDumpManager" to "ClientProcess"
   

On top of this, this CL does two minor cleanups in the memory-infra codebase:
- Using new THREAD_CHECKER macro instead of the ThreadChecker class
   (reduces size on non-debug builds).
- Sorts out the ...ForTesting() pattern in MemoryDumpManager, removing the
   need of friend-ing a class outside of its folder.

BUG=703184
TBR=jochen@chromium.org
==========

to

==========
memory-infra: rename service folder to memory_instrumentation

This is a non-functional refactoring that renamed the memory
instrumentation code within //services/resource_coordinator. Due to
projects/people reshuffling the code ended up being moved
into memory/coordinator that doesn't reflect what the code
inside does (it deals only with instrumentation). Furthermore it is extremely
confusing, as there is a "memory coordinator" project happening in chrome,
which is completely orthogonal with this.

The renames consists of:
- Move the code in //services/resource_coordinator
  from memory/coordinator/ to memory_instrumentation
- Ditto for the public library code in
  //services/resource_coordinator/public/cpp and
  //services/resource_coordinator/public/interfaces
- Rename the class in the client library that handshakes with the
  Coordinator in the service and deals with in-process dumps
  from "ProcessLocalDumpManager" to "ClientProcess"
   

On top of this, this CL does two minor cleanups in the memory-infra codebase:
- Using new THREAD_CHECKER macro instead of the ThreadChecker class
   (reduces size on non-debug builds).
- Sorts out the ...ForTesting() pattern in MemoryDumpManager, removing the
   need of friend-ing a class outside of its folder.

BUG=703184
TBR=jochen@chromium.org

Review-Url: https://codereview.chromium.org/2895083004
Cr-Commit-Position: refs/heads/master@{#473568}
Committed:
https://chromium.googlesource.com/chromium/src/+/aca468f8904f44043315a0366c64...
==========

[commit-bot: I haz the power, 2017-05-22 13:30:50]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/aca468f8904f44043315a0366c64...