Improve Visual Studio debug visualizers

Improve Visual Studio debug visualizers

Links the native visualizers into the PDB so that Visual Studio will pick up the visualizers with no user action.

Adds visualizers for base::flat_set, base::flat_tree (these two had the info buried in several levels of tree), base::ManualConstructor (requires a cast), and base::Value (decodes the union).

Removes some aura visualizers. I didn't see these as adding much value.

Simplifies many of the other visualizers to only improve the summary and not list any <Expand> items. This causes VS to show the default expansion. Many of these seemed unhelpful and possibly confusing (converting gfx::Point's "x_" to "X"), dangerously misleading (converting Skia's rect which is left, top, right, button to use width, height format), and broken (GURL's components had typos and didn't work).

Review-Url: https://codereview.chromium.org/2895043002
Cr-Commit-Position: refs/heads/master@{#473767}
Committed: https://chromium.googlesource.com/chromium/src/+/2187893b82e8052ff073ee1bdb940f7ac94f19e6

[brettw, 2017-05-21 04:44:21]

More

[brettw, 2017-05-21 04:52:39]

flat_set

[brettw, 2017-05-21 04:56:23]

Description was changed from

==========
Add Visual Studio native visualizers

BUG=
==========

to

==========
Improve Visual Studio debug visualizers

Links the native visualizers into the PDB so that Visual Studio will pick up the
visualizers with no user action.

Adds visualizers for base::flat_set, base::flat_tree (these two had the info
buried in several levels of tree), base::ManuaalConstructor (requires a cast),
and base::Value (decodes the union).

Removes some aura visualizers. I didn't see these as adding much value.

Simplifies many of the other visualizers to only improve the summary and not
list any <Expand> items. This causes VS to show the default expansion. Many of
these seemed unhelpful and possibly confusing (converting gfx::Point's "x_" to
"X"), dangerously misleading (converting Skia's rect which is left, top, right,
button to use width, height format), and broken (GURL's components had typos and
didn't work).
==========

[brettw, 2017-05-21 04:56:23]

brettw@chromium.org changed reviewers:
+ brucedawson@chromium.org

[brettw, 2017-05-21 04:57:34]

Typo

[brettw, 2017-05-21 04:58:25]

Skia typo

[brettw, 2017-05-21 04:58:28]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-21 04:58:45]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-21 08:38:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-21 08:38:30]

Dry run: This issue passed the CQ dry run.

[brucedawson, 2017-05-22 21:41:54]

Description was changed from

==========
Improve Visual Studio debug visualizers

Links the native visualizers into the PDB so that Visual Studio will pick up the
visualizers with no user action.

Adds visualizers for base::flat_set, base::flat_tree (these two had the info
buried in several levels of tree), base::ManuaalConstructor (requires a cast),
and base::Value (decodes the union).

Removes some aura visualizers. I didn't see these as adding much value.

Simplifies many of the other visualizers to only improve the summary and not
list any <Expand> items. This causes VS to show the default expansion. Many of
these seemed unhelpful and possibly confusing (converting gfx::Point's "x_" to
"X"), dangerously misleading (converting Skia's rect which is left, top, right,
button to use width, height format), and broken (GURL's components had typos and
didn't work).
==========

to

==========
Improve Visual Studio debug visualizers

Links the native visualizers into the PDB so that Visual Studio will pick up the
visualizers with no user action.

Adds visualizers for base::flat_set, base::flat_tree (these two had the info
buried in several levels of tree), base::ManualConstructor (requires a cast),
and base::Value (decodes the union).

Removes some aura visualizers. I didn't see these as adding much value.

Simplifies many of the other visualizers to only improve the summary and not
list any <Expand> items. This causes VS to show the default expansion. Many of
these seemed unhelpful and possibly confusing (converting gfx::Point's "x_" to
"X"), dangerously misleading (converting Skia's rect which is left, top, right,
button to use width, height format), and broken (GURL's components had typos and
didn't work).
==========

[brucedawson, 2017-05-22 21:44:10]

Thanks for discovering this. lgtm.

[brettw, 2017-05-22 22:15:39]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2017-05-22 22:16:03]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 00:52:30]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1495491339565030,
"parent_rev": "4df44c0cf2a2ea02bdc4f08a86d2827a5be2b487", "commit_rev":
"2187893b82e8052ff073ee1bdb940f7ac94f19e6"}

[commit-bot: I haz the power, 2017-05-23 00:52:38]

Description was changed from

==========
Improve Visual Studio debug visualizers

Links the native visualizers into the PDB so that Visual Studio will pick up the
visualizers with no user action.

Adds visualizers for base::flat_set, base::flat_tree (these two had the info
buried in several levels of tree), base::ManualConstructor (requires a cast),
and base::Value (decodes the union).

Removes some aura visualizers. I didn't see these as adding much value.

Simplifies many of the other visualizers to only improve the summary and not
list any <Expand> items. This causes VS to show the default expansion. Many of
these seemed unhelpful and possibly confusing (converting gfx::Point's "x_" to
"X"), dangerously misleading (converting Skia's rect which is left, top, right,
button to use width, height format), and broken (GURL's components had typos and
didn't work).
==========

to

==========
Improve Visual Studio debug visualizers

Links the native visualizers into the PDB so that Visual Studio will pick up the
visualizers with no user action.

Adds visualizers for base::flat_set, base::flat_tree (these two had the info
buried in several levels of tree), base::ManualConstructor (requires a cast),
and base::Value (decodes the union).

Removes some aura visualizers. I didn't see these as adding much value.

Simplifies many of the other visualizers to only improve the summary and not
list any <Expand> items. This causes VS to show the default expansion. Many of
these seemed unhelpful and possibly confusing (converting gfx::Point's "x_" to
"X"), dangerously misleading (converting Skia's rect which is left, top, right,
button to use width, height format), and broken (GURL's components had typos and
didn't work).

Review-Url: https://codereview.chromium.org/2895043002
Cr-Commit-Position: refs/heads/master@{#473767}
Committed:
https://chromium.googlesource.com/chromium/src/+/2187893b82e8052ff073ee1bdb94...
==========

[commit-bot: I haz the power, 2017-05-23 00:52:39]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/2187893b82e8052ff073ee1bdb94...