Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2895013003: Image Capture Mac: make setOptions() resolve the callback with true (Closed)

Created:
3 years, 7 months ago by mcasas
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews, posciak+watch_chromium.org, chfremer+watch_chromium.org, feature-media-reviews_chromium.org, mac-reviews_chromium.org, xjz+watch_chromium.org, miu+watch_chromium.org
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Image Capture Mac: make setOptions() resolve the callback with true This CL implements VideoCaptureDevice::setOptions() for Mac so that we can resolve the callback with a true value -- setPhotoOptionsCallback on ToT resolves |callback| with false if not explicitly Run() and Blink will think it has failed. Bug: 723929 Change-Id: I2c9f0ec482538f7f1c389ea4bc970552fd39e324 Reviewed-on: https://chromium-review.googlesource.com/508183 Commit-Queue: Miguel Casas <mcasas@chromium.org>; Reviewed-by: Vincent Scheib <scheib@chromium.org>; Cr-Commit-Position: refs/heads/master@{#472994} (cherry picked from commit 8d9d6d4fd30cc0e8840ef957dfbd7e996fe7a498) NOTRY=True NOPRESUBMIT=True TBR=scheib@chromium.org Review-Url: https://codereview.chromium.org/2895013003 Cr-Commit-Position: refs/branch-heads/3071@{#641} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/347764e21457f5dfc357ec4a0fc9374b1f011d17

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M media/capture/video/mac/video_capture_device_mac.h View 1 chunk +2 lines, -0 lines 0 comments Download
M media/capture/video/mac/video_capture_device_mac.mm View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2895013003/1
3 years, 7 months ago (2017-05-20 01:12:50 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 7 months ago (2017-05-20 01:12:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2895013003/1
3 years, 7 months ago (2017-05-20 01:14:50 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-20 01:16:30 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/347764e21457f5dfc357ec4a0fc9...

Powered by Google App Engine
This is Rietveld 408576698