chrome/browser/ui/browser_tab_strip_model_delegate.cc - Issue 2894973002: Provide WebContents::CreateParams to tab helpers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_tab_strip_model_delegate.cc

Issue 2894973002: Provide WebContents::CreateParams to tab helpers. (Closed)

Patch Set: rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/browser_tab_strip_model_delegate.cc

diff --git a/chrome/browser/ui/browser_tab_strip_model_delegate.cc b/chrome/browser/ui/browser_tab_strip_model_delegate.cc

index 8788e4a8b3584c0ce337a3963667143a20de6f0a..0b2cb4307859ba8deee6d5089340588bee9dcb84 100644

--- a/chrome/browser/ui/browser_tab_strip_model_delegate.cc

+++ b/chrome/browser/ui/browser_tab_strip_model_delegate.cc

@@ -86,7 +86,7 @@ Browser* BrowserTabStripModelDelegate::CreateNewStripWithContents(

void BrowserTabStripModelDelegate::WillAddWebContents(

content::WebContents* contents) {

- TabHelpers::AttachTabHelpers(contents);

+ TabHelpers::AttachTabHelpers(contents, base::nullopt);

// Make the tab show up in the task manager.

task_manager::WebContentsTags::CreateForTabContents(contents);

« no previous file with comments | « chrome/browser/ui/browser_navigator.cc ('k') | chrome/browser/ui/tab_helpers.h » ('j') | no next file with comments »