Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2637)

Unified Diff: chrome/browser/ui/browser_navigator.cc

Issue 2894973002: Provide WebContents::CreateParams to tab helpers. (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/browser.cc ('k') | chrome/browser/ui/browser_tab_strip_model_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser_navigator.cc
diff --git a/chrome/browser/ui/browser_navigator.cc b/chrome/browser/ui/browser_navigator.cc
index e8190f627e85602f6c76f35a3bd53c148b133aae..abf993f818697581907ccd20f65fb0941d6c09be 100644
--- a/chrome/browser/ui/browser_navigator.cc
+++ b/chrome/browser/ui/browser_navigator.cc
@@ -61,8 +61,10 @@ using content::WebContents;
class BrowserNavigatorWebContentsAdoption {
public:
- static void AttachTabHelpers(content::WebContents* contents) {
- TabHelpers::AttachTabHelpers(contents);
+ static void AttachTabHelpers(
+ content::WebContents* contents,
+ const base::Optional<WebContents::CreateParams>& create_params) {
+ TabHelpers::AttachTabHelpers(contents, create_params);
// Make the tab show up in the task manager.
task_manager::WebContentsTags::CreateForTabContents(contents);
@@ -381,7 +383,8 @@ content::WebContents* CreateTargetContents(const chrome::NavigateParams& params,
// New tabs can have WebUI URLs that will make calls back to arbitrary
// tab helpers, so the entire set of tab helpers needs to be set up
// immediately.
- BrowserNavigatorWebContentsAdoption::AttachTabHelpers(target_contents);
+ BrowserNavigatorWebContentsAdoption::AttachTabHelpers(target_contents,
+ create_params);
#if BUILDFLAG(ENABLE_EXTENSIONS)
extensions::TabHelper::FromWebContents(target_contents)->
SetExtensionAppById(params.extension_app_id);
« no previous file with comments | « chrome/browser/ui/browser.cc ('k') | chrome/browser/ui/browser_tab_strip_model_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698