Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2894933002:
Ensure clock advances in test between create and exit. (Closed)
DescriptionEnsure clock advances in test between create and exit.
There is a check in the tracker to ignore processes with a create-
time greater or equal than the current time in order to not mistake
a currently-running process that has reused a PID for an exited
one.
BUG=723060
Review-Url: https://codereview.chromium.org/2894933002
Cr-Commit-Position: refs/heads/master@{#473873}
Committed: https://chromium.googlesource.com/chromium/src/+/f04e36c1450b210d10cbffb115c72c6676b58a8e
Patch Set 1 #
Total comments: 2
Patch Set 2 : use past stamp when setting owner #Messages
Total messages: 24 (15 generated)
The CQ bit was checked by bcwhite@chromium.org to run a CQ dry run
bcwhite@chromium.org changed reviewers: + manzagop@chromium.org
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2894933002/diff/1/base/debug/activity_tracker... File base/debug/activity_tracker_unittest.cc (right): https://codereview.chromium.org/2894933002/diff/1/base/debug/activity_tracker... base/debug/activity_tracker_unittest.cc:467: while (Time::Now().ToInternalValue() <= stamp) Could you instead use a timestamp in the past when you SetOwningProcessIdForTesting?
The CQ bit was checked by bcwhite@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2894933002/diff/1/base/debug/activity_tracker... File base/debug/activity_tracker_unittest.cc (right): https://codereview.chromium.org/2894933002/diff/1/base/debug/activity_tracker... base/debug/activity_tracker_unittest.cc:467: while (Time::Now().ToInternalValue() <= stamp) On 2017/05/19 17:35:21, manzagop wrote: > Could you instead use a timestamp in the past when you > SetOwningProcessIdForTesting? Done.
manzagop@google.com changed reviewers: + manzagop@google.com
lgtm
The CQ bit was checked by bcwhite@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
lgtm
The CQ bit was checked by bcwhite@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495543984666840,
"parent_rev": "353a96e9ef4fe92c8808aac4acec49b2a7527109", "commit_rev":
"f04e36c1450b210d10cbffb115c72c6676b58a8e"}
Message was sent while issue was closed.
Description was changed from ========== Ensure clock advances in test between create and exit. There is a check in the tracker to ignore processes with a create- time greater or equal than the current time in order to not mistake a currently-running process that has reused a PID for an exited one. BUG=723060 ========== to ========== Ensure clock advances in test between create and exit. There is a check in the tracker to ignore processes with a create- time greater or equal than the current time in order to not mistake a currently-running process that has reused a PID for an exited one. BUG=723060 Review-Url: https://codereview.chromium.org/2894933002 Cr-Commit-Position: refs/heads/master@{#473873} Committed: https://chromium.googlesource.com/chromium/src/+/f04e36c1450b210d10cbffb115c7... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/f04e36c1450b210d10cbffb115c7... |
