Fix dataset type conversion bug in uber.js

Fix dataset type conversion bug in uber.js

dataset property of HTMLElemenet converts all of its subproperties to
string. So if someone writes 'element.dataset.subProp = false;',
condition 'if (!element.dtaset.subProp) { doSmth(); }' will be never
fullfilled.

uber.js had this bug in 'invokeMethodOnPage' function. So if the frame
was reinited, methods on subpage in this frame were invoked immediately
instead of waiting for 'pageReady' event.

R=dbeam@chromium.org
BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2894923002
Cr-Commit-Position: refs/heads/master@{#473441}
Committed: https://chromium.googlesource.com/chromium/src/+/9afb0f4cfef525149c61f8f2629546dd76c03023

[mkraynov, 2017-05-19 16:35:33]

Description was changed from

==========
Fix dataset type conversion bug in uber.js

dataset property of HTMLElemenet converts all of its subproperties to
string. So if someone writes 'element.dataset.subProp = false;',
condition 'if (!element.dtaset.subProp) { doSmth(); }' will be never
fullfilled.

uber.js had this bug in 'invokeMethodOnPage' function. So if the frame
was reinited, methods on subpage in this frame were invoked immediately
instead of waiting for 'pageReady' event.

R=dbeam@chromium.org
BUG=None
==========

to

==========
Fix dataset type conversion bug in uber.js

dataset property of HTMLElemenet converts all of its subproperties to
string. So if someone writes 'element.dataset.subProp = false;',
condition 'if (!element.dtaset.subProp) { doSmth(); }' will be never
fullfilled.

uber.js had this bug in 'invokeMethodOnPage' function. So if the frame
was reinited, methods on subpage in this frame were invoked immediately
instead of waiting for 'pageReady' event.

R=dbeam@chromium.org
BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2017-05-19 19:33:59]

lgtm but did you try the change locally?  maybe via chrome://extensions or
disabling the new Material Design Settings page and visiting chrome://settings?

[mkraynov, 2017-05-19 23:24:13]

On 2017/05/19 19:33:59, Dan Beam wrote:
> lgtm but did you try the change locally?  maybe via chrome://extensions or
> disabling the new Material Design Settings page and visiting
chrome://settings?

Yeah. I've tried it. I've made artificial tests with console.log order from
'invokeMethodOnPage' and 'pageReady'.

Besides we still use pre-MD chrome://settings in Yandex.Browser (based on
Chromium). And we have code using 'invokeMethodOnPage' function. So this fix is
based on real-life bug.

[mkraynov, 2017-05-19 23:25:29]

The CQ bit was checked by mkraynov@yandex-team.ru

[mkraynov, 2017-05-19 23:25:51]

The CQ bit was unchecked by mkraynov@yandex-team.ru

[mkraynov, 2017-05-19 23:25:55]

The CQ bit was checked by mkraynov@yandex-team.ru

[mkraynov, 2017-05-19 23:26:18]

The CQ bit was unchecked by mkraynov@yandex-team.ru

[mkraynov, 2017-05-19 23:27:17]

The CQ bit was checked by mkraynov@yandex-team.ru to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 23:27:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 23:38:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 23:38:37]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[mkraynov, 2017-05-20 15:14:44]

The CQ bit was checked by mkraynov@yandex-team.ru

[commit-bot: I haz the power, 2017-05-20 15:14:54]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-20 15:56:40]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1495293284661500, "parent_rev":
"8fc59ec5661e2fe217f857900b1c287f4a820b26", "commit_rev":
"9afb0f4cfef525149c61f8f2629546dd76c03023"}

[commit-bot: I haz the power, 2017-05-20 15:56:51]

Description was changed from

==========
Fix dataset type conversion bug in uber.js

dataset property of HTMLElemenet converts all of its subproperties to
string. So if someone writes 'element.dataset.subProp = false;',
condition 'if (!element.dtaset.subProp) { doSmth(); }' will be never
fullfilled.

uber.js had this bug in 'invokeMethodOnPage' function. So if the frame
was reinited, methods on subpage in this frame were invoked immediately
instead of waiting for 'pageReady' event.

R=dbeam@chromium.org
BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Fix dataset type conversion bug in uber.js

dataset property of HTMLElemenet converts all of its subproperties to
string. So if someone writes 'element.dataset.subProp = false;',
condition 'if (!element.dtaset.subProp) { doSmth(); }' will be never
fullfilled.

uber.js had this bug in 'invokeMethodOnPage' function. So if the frame
was reinited, methods on subpage in this frame were invoked immediately
instead of waiting for 'pageReady' event.

R=dbeam@chromium.org
BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2894923002
Cr-Commit-Position: refs/heads/master@{#473441}
Committed:
https://chromium.googlesource.com/chromium/src/+/9afb0f4cfef525149c61f8f26295...
==========

[commit-bot: I haz the power, 2017-05-20 15:56:52]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9afb0f4cfef525149c61f8f26295...