Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3291)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchUma.java

Issue 2894913003: [TTS] Move Ranker logging to inference time. (Closed)
Patch Set: Fix some asserts and minor cleanup. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchUma.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchUma.java b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchUma.java
index b1acdc6183018c7b86a0e7d97431344f19295235..d731f3467e7f4c64c94edecafb7a61bfd09e0b22 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchUma.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchUma.java
@@ -803,6 +803,26 @@ public class ContextualSearchUma {
}
/**
+ * Logs whether results were seen and whether UI-suppression was recommended by Ranker.
+ * @param wasSearchContentViewSeen If the panel was opened.
+ * @param wasUiSuppressionRecommendedByRanker Whether Ranker would have recommended that the UI
+ * be suppressed.
+ */
+ public static void logRankerInferenceResultsSeen(
Theresa 2017/05/30 20:25:25 It seems a tad premature to add these histograms s
Donn Denman 2017/05/30 23:13:25 Good point! I got carried away with collecting dat
+ boolean wasSearchContentViewSeen, boolean wasUiSuppressionRecommendedByRanker) {
+ if (wasUiSuppressionRecommendedByRanker) {
+ RecordHistogram.recordEnumeratedHistogram("Search.ContextualSearchRankerSuppressedSeen",
+ wasSearchContentViewSeen ? RESULTS_SEEN : RESULTS_NOT_SEEN,
+ RESULTS_SEEN_BOUNDARY);
+ } else {
+ RecordHistogram.recordEnumeratedHistogram(
+ "Search.ContextualSearchNotRankerSuppressedSeen",
+ wasSearchContentViewSeen ? RESULTS_SEEN : RESULTS_NOT_SEEN,
+ RESULTS_SEEN_BOUNDARY);
+ }
+ }
+
+ /**
* Logs whether results were seen and whether any tap suppression heuristics were satisfied.
* @param wasSearchContentViewSeen If the panel was opened.
* @param wasAnySuppressionHeuristicSatisfied Whether any of the implemented suppression

Powered by Google App Engine
This is Rietveld 408576698