Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issue 2894913002: Revert "VM: Constant fold more loads from constants in the optimizer." (Closed)

Created:
3 years, 7 months ago by Vyacheslav Egorov (Google)
Modified:
3 years, 7 months ago
Reviewers:
kustermann
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "VM: Constant fold more loads from constants in the optimizer." This reverts commit 746ab58f4623372e1efcfd04644927f16dd0fab7. Reason: precompiler tests broke python tools/test.py -mrelease -cprecompiler -rdart_precompiled -aarm -sandroid --use-blobs -t480 corelib/string_test python tools/test.py -mrelease -cprecompiler -rdart_precompiled -aarm -sandroid --use-blobs -t480 corelib/list_test/none python tools/test.py -mrelease -cprecompiler -rdart_precompiled -aarm -sandroid --use-blobs -t480 corelib/list_test/01 TBR=kustermann@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/1040fefdea3d4190a236f1ba95ae0ca21f254899

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -82 lines) Patch
M runtime/vm/constant_propagator.cc View 1 chunk +14 lines, -17 lines 0 comments Download
M runtime/vm/intermediate_language.h View 1 chunk +0 lines, -7 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 1 chunk +26 lines, -58 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Vyacheslav Egorov (Google)
3 years, 7 months ago (2017-05-19 15:17:32 UTC) #1
kustermann
lgtm
3 years, 7 months ago (2017-05-19 15:17:52 UTC) #2
Vyacheslav Egorov (Google)
3 years, 7 months ago (2017-05-19 15:17:56 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1040fefdea3d4190a236f1ba95ae0ca21f254899 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698