Revert "VM: Constant fold more loads from constants in the optimizer."

runtime/vm/intermediate_language.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/intermediate_language.h"
 
 #include "vm/bit_vector.h"
 #include "vm/bootstrap.h"
 #include "vm/compiler.h"
 #include "vm/constant_propagator.h"
@@ skipping 2103 matching lines @@
 
 
 // A math unary instruction has a side effect (exception
 // thrown) if the argument is not a number.
 // TODO(srdjan): eliminate if has no uses and input is guaranteed to be number.
 Definition* MathUnaryInstr::Canonicalize(FlowGraph* flow_graph) {
   return this;
 }
 
 
-bool LoadFieldInstr::Evaluate(const Object& instance, Object* result) {
-  if (field() == NULL || !field()->is_final() || !instance.IsInstance()) {
-    return false;
-  }
-
-  // Check that instance really has the field which we
-  // are trying to load from.
-  Class& cls = Class::Handle(instance.clazz());
-  while (cls.raw() != Class::null() && cls.raw() != field()->Owner()) {
-    cls = cls.SuperClass();
-  }
-  if (cls.raw() != field()->Owner()) {
-    // Failed to find the field in class or its superclasses.
-    return false;
-  }
-
-  // Object has the field: execute the load.
-  *result = Instance::Cast(instance).GetField(*field());
-  return true;
-}
-
-
 Definition* LoadFieldInstr::Canonicalize(FlowGraph* flow_graph) {
   if (!HasUses()) return NULL;
+  if (!IsImmutableLengthLoad()) return this;
 
-  if (IsImmutableLengthLoad()) {
-    // For fixed length arrays if the array is the result of a known constructor
-    // call we can replace the length load with the length argument passed to
-    // the constructor.
-    StaticCallInstr* call =
-        instance()->definition()->OriginalDefinition()->AsStaticCall();
-    if (call != NULL) {
-      if (call->is_known_list_constructor() &&
-          IsFixedLengthArrayCid(call->Type()->ToCid())) {
-        return call->ArgumentAt(1);
-      }
-    }
-
-    CreateArrayInstr* create_array =
-        instance()->definition()->OriginalDefinition()->AsCreateArray();
-    if ((create_array != NULL) &&
-        (recognized_kind() == MethodRecognizer::kObjectArrayLength)) {
-      return create_array->num_elements()->definition();
-    }
-
-    // For arrays with guarded lengths, replace the length load
-    // with a constant.
-    LoadFieldInstr* load_array =
-        instance()->definition()->OriginalDefinition()->AsLoadField();
-    if (load_array != NULL) {
-      const Field* field = load_array->field();
-      if ((field != NULL) && (field->guarded_list_length() >= 0)) {
-        return flow_graph->GetConstant(
-            Smi::Handle(Smi::New(field->guarded_list_length())));
-      }
+  // For fixed length arrays if the array is the result of a known constructor
+  // call we can replace the length load with the length argument passed to
+  // the constructor.
+  StaticCallInstr* call =
+      instance()->definition()->OriginalDefinition()->AsStaticCall();
+  if (call != NULL) {
+    if (call->is_known_list_constructor() &&
+        IsFixedLengthArrayCid(call->Type()->ToCid())) {
+      return call->ArgumentAt(1);
     }
   }
 
-  // Try folding away loads from constant objects.
-  if (instance()->BindsToConstant()) {
-    Object& result = Object::Handle();
-    if (Evaluate(instance()->BoundConstant(), &result)) {
-      return flow_graph->GetConstant(result);
+  CreateArrayInstr* create_array =
+      instance()->definition()->OriginalDefinition()->AsCreateArray();
+  if ((create_array != NULL) &&
+      (recognized_kind() == MethodRecognizer::kObjectArrayLength)) {
+    return create_array->num_elements()->definition();
+  }
+
+  // For arrays with guarded lengths, replace the length load
+  // with a constant.
+  LoadFieldInstr* load_array =
+      instance()->definition()->OriginalDefinition()->AsLoadField();
+  if (load_array != NULL) {
+    const Field* field = load_array->field();
+    if ((field != NULL) && (field->guarded_list_length() >= 0)) {
+      return flow_graph->GetConstant(
+          Smi::Handle(Smi::New(field->guarded_list_length())));
     }
   }
-
   return this;
 }
 
 
 Definition* AssertBooleanInstr::Canonicalize(FlowGraph* flow_graph) {
   if (FLAG_eliminate_type_checks && (value()->Type()->ToCid() == kBoolCid)) {
     return value()->definition();
   }
 
   return this;
@@ skipping 2142 matching lines @@
                      "native function '%s' (%" Pd " arguments) cannot be found",
                      native_name().ToCString(), function().NumParameters());
   }
   set_is_auto_scope(auto_setup_scope);
   set_native_c_function(native_function);
 }
 
 #undef __
 
 }  // namespace dart