VR: Fix invalidation race viewing native pages.

VR: Fix invalidation race viewing native pages.

If the NativePage finishes drawing before we connect a surface for it to draw into, then it won't redraw into the surface unless we invalidate it.

We were only partially handling this previously, and weren't invalidating as much as we needed to.

This also fixes a possible race that could trigger unnecessary recreation of our content surface when switching between NativePages and WebContents.

BUG=717244
Review-Url: https://codereview.chromium.org/2894903002
Cr-Commit-Position: refs/heads/master@{#473265}
Committed: https://chromium.googlesource.com/chromium/src/+/e26a4859564edfca90ad1919a83a6e43aed2a9eb

[mthiesse, 2017-05-19 15:10:08]

mthiesse@chromium.org changed reviewers:
+ ymalik@chromium.org

[mthiesse, 2017-05-19 15:10:09]

PTAL

[ymalik, 2017-05-19 17:23:34]

nit: regarding descriptions, I generally find it helpful when instead of just
saying what this CL does, having a short blurb on what the problem was, and how
does your change fix it.

For example
<Title: this Cl fixes this>
<Description: this is what was happening...>
<Fix: we do this now, so this is no longer an issue>

Obviously this doesn't apply for all CLs, but it give the right context for
reviewing.

Also, wrapping the CL description at 80 characters looks nice :)

https://codereview.chromium.org/2894903002/diff/20001/chrome/browser/android/...
File chrome/browser/android/vr_shell/vr_shell.cc (right):

https://codereview.chromium.org/2894903002/diff/20001/chrome/browser/android/...
chrome/browser/android/vr_shell/vr_shell.cc:428: if (!taken_surface_)
should we be restoring taken_surface_ to false?

[mthiesse, 2017-05-19 17:57:40]

Description was changed from

==========
VR: Fix invalidation race viewing native pages.

BUG=717244
==========

to

==========
VR: Fix invalidation race viewing native pages.

If the NativePage finishes drawing before we connect a surface for it to draw
into, then it won't redraw into the surface unless we invalidate it.

We were only partially handling this previously, and weren't invalidating as
much as we needed to.

This also fixes a possible race that could trigger unnecessary recreation of our
content surface when switching between NativePages and WebContents.

BUG=717244
==========

[mthiesse, 2017-05-19 17:59:09]

Updated description.

https://codereview.chromium.org/2894903002/diff/20001/chrome/browser/android/...
File chrome/browser/android/vr_shell/vr_shell.cc (right):

https://codereview.chromium.org/2894903002/diff/20001/chrome/browser/android/...
chrome/browser/android/vr_shell/vr_shell.cc:428: if (!taken_surface_)
On 2017/05/19 17:23:34, ymalik wrote:
> should we be restoring taken_surface_ to false?

Oops yes.

[ymalik, 2017-05-19 18:06:56]

lgtm

[mthiesse, 2017-05-19 18:07:35]

The CQ bit was checked by mthiesse@chromium.org

[commit-bot: I haz the power, 2017-05-19 18:08:16]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 19:01:07]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495217255690250,
"parent_rev": "45167d8df4bc03bdbecbc9009901528ce9349226", "commit_rev":
"e26a4859564edfca90ad1919a83a6e43aed2a9eb"}

[commit-bot: I haz the power, 2017-05-19 19:01:17]

Description was changed from

==========
VR: Fix invalidation race viewing native pages.

If the NativePage finishes drawing before we connect a surface for it to draw
into, then it won't redraw into the surface unless we invalidate it.

We were only partially handling this previously, and weren't invalidating as
much as we needed to.

This also fixes a possible race that could trigger unnecessary recreation of our
content surface when switching between NativePages and WebContents.

BUG=717244
==========

to

==========
VR: Fix invalidation race viewing native pages.

If the NativePage finishes drawing before we connect a surface for it to draw
into, then it won't redraw into the surface unless we invalidate it.

We were only partially handling this previously, and weren't invalidating as
much as we needed to.

This also fixes a possible race that could trigger unnecessary recreation of our
content surface when switching between NativePages and WebContents.

BUG=717244

Review-Url: https://codereview.chromium.org/2894903002
Cr-Commit-Position: refs/heads/master@{#473265}
Committed:
https://chromium.googlesource.com/chromium/src/+/e26a4859564edfca90ad1919a83a...
==========

[commit-bot: I haz the power, 2017-05-19 19:01:18]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e26a4859564edfca90ad1919a83a...