Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2894883003: Upstream service worker tests to WPT (Closed)

Created:
3 years, 7 months ago by mike3
Modified:
3 years, 7 months ago
Reviewers:
falken
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, blink-reviews-w3ctests_chromium.org, nhiroki, kinuko+serviceworker, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, tzik
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream service worker "script URL" test to WPT This test is nearly identical to the version available in the Web Platform Tests project. Update the upstream version with the only meaningful difference between the tests: an additional assertion for the interpretation of fragment identifiers. Re-factor test body to use `promise_test` and format code accordingly. Add a "use strict" directive. Remove the Chromium version of the test. BUG=688116 R=falken@chromium.org Review-Url: https://codereview.chromium.org/2894883003 Cr-Commit-Position: refs/heads/master@{#473586} Committed: https://chromium.googlesource.com/chromium/src/+/a51bf4dc7726796505882c1b96eed0ec40c28d4f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -41 lines) Patch
M third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/serviceworkerobject-scripturl.https.html View 1 chunk +18 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/serviceworker/serviceworkerobject-scripturl.html View 1 chunk +0 lines, -28 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
mike3
Hey Matt, Here's the diff for this one: https://gist.github.com/jugglinmike/30eda43475da2e759d270442f15192bc
3 years, 7 months ago (2017-05-19 21:53:12 UTC) #2
mike3
On 2017/05/19 21:53:12, mike3 wrote: > Hey Matt, > > Here's the diff for this ...
3 years, 7 months ago (2017-05-19 21:54:07 UTC) #3
falken
lgtm
3 years, 7 months ago (2017-05-22 04:27:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2894883003/1
3 years, 7 months ago (2017-05-22 14:45:13 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-22 16:11:09 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a51bf4dc7726796505882c1b96ee...

Powered by Google App Engine
This is Rietveld 408576698