Rename TaskRunner::RunsTasksOnCurrentThread() in //net

Rename TaskRunner::RunsTasksOnCurrentThread() in //net

renamed TaskRunner::RunsTasksOnCurrentThread() to
TaskRunner::RunsTasksInCurrentSequence() in //net

BUG=665062
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2894863002
Cr-Commit-Position: refs/heads/master@{#476185}
Committed: https://chromium.googlesource.com/chromium/src/+/aeac7780cf8392c00b9179fd09aed830fe9fbe22

[Yeol Park, 2017-05-22 04:08:24]

Description was changed from

==========
Rename TaskRunner::RunsTasksOnCurrentThread() in //net

renamed TaskRunner::RunsTasksOnCurrentThread() to
TaskRunner::RunsTasksInCurrentSequence() in //net

BUG=665062
==========

to

==========
Rename TaskRunner::RunsTasksOnCurrentThread() in //net

renamed TaskRunner::RunsTasksOnCurrentThread() to
TaskRunner::RunsTasksInCurrentSequence() in //net

BUG=665062
==========

[Yeol Park, 2017-05-22 04:08:24]

peary2@gmail.com changed reviewers:
+ bnc@chromium.org, rsleevi@chromium.org

[Yeol Park, 2017-05-22 04:08:41]

I separated //net from patch codereview.chromium.org/2886403003.
for the character and history of //net
 
rsleevi@
Thank you for your information. :)
I updated at the patch set2 for your comment.
(codereview.chromium.org/2886403003/#msg4)

I need your advice for right direction of this patch.

PTAL :)
+bnc@,  rsleevi@

[Ryan Sleevi, 2017-05-22 17:22:14]

I'm not sure whether you want to go with On*TaskRunner or On*Sequence, but since
you seemed to go with On*Sequence with other changes, I went with that.

Whichever is conceptually aligned with this overall effort - that things are
associated to specific TaskRunners or to specific Sequences (To me, I personally
go with "On*TaskRunner", but I can see where "On*Sequence" indicates a more
direct statement that the method is sequenced against other events)

LGTM % nits :)

https://codereview.chromium.org/2894863002/diff/20001/net/base/directory_list...
File net/base/directory_lister.cc (right):

https://codereview.chromium.org/2894863002/diff/20001/net/base/directory_list...
net/base/directory_lister.cc:106: void
DirectoryLister::Core::CancelOnOriginThread() {
CancelOnOriginSequence ?

https://codereview.chromium.org/2894863002/diff/20001/net/base/directory_list...
net/base/directory_lister.cc:176: void
DirectoryLister::Core::DoneOnOriginThread(
DoneOnOriginSequence

https://codereview.chromium.org/2894863002/diff/20001/net/cert_net/cert_net_f...
File net/cert_net/cert_net_fetcher_impl.cc (right):

https://codereview.chromium.org/2894863002/diff/20001/net/cert_net/cert_net_f...
net/cert_net/cert_net_fetcher_impl.cc:772: void
DoFetchOnNetworkThread(std::unique_ptr<RequestParams> request_params,
DoFetchOnNetworkSequence

https://codereview.chromium.org/2894863002/diff/20001/net/http/http_server_pr...
File net/http/http_server_properties_manager.cc (right):

https://codereview.chromium.org/2894863002/diff/20001/net/http/http_server_pr...
net/http/http_server_properties_manager.cc:101: void
HttpServerPropertiesManager::InitializeOnNetworkThread() {
OnNetworkSequence?

https://codereview.chromium.org/2894863002/diff/20001/net/http/http_server_pr...
net/http/http_server_properties_manager.cc:121: void
HttpServerPropertiesManager::ShutdownOnPrefThread() {
OnPrefSequence?

https://codereview.chromium.org/2894863002/diff/20001/net/http/http_server_pr...
net/http/http_server_properties_manager.cc:393: void
HttpServerPropertiesManager::ScheduleUpdateCacheOnPrefThread() {
OnPrefSequence

https://codereview.chromium.org/2894863002/diff/20001/net/http/http_server_pr...
net/http/http_server_properties_manager.cc:404: void
HttpServerPropertiesManager::UpdateCacheFromPrefsOnPrefThread() {
OnPrefSequence

https://codereview.chromium.org/2894863002/diff/20001/net/http/http_server_pr...
net/http/http_server_properties_manager.cc:774: void
HttpServerPropertiesManager::UpdateCacheFromPrefsOnNetworkThread(
OnNetworkSequence

https://codereview.chromium.org/2894863002/diff/20001/net/http/http_server_pr...
net/http/http_server_properties_manager.cc:812: void
HttpServerPropertiesManager::ScheduleUpdatePrefsOnNetworkThread(
OnNetworkSequence

https://codereview.chromium.org/2894863002/diff/20001/net/http/http_server_pr...
net/http/http_server_properties_manager.cc:833: void
HttpServerPropertiesManager::UpdatePrefsFromCacheOnNetworkThread(
OnNetworkSequence

https://codereview.chromium.org/2894863002/diff/20001/net/nqe/network_qualiti...
File net/nqe/network_qualities_prefs_manager.cc (right):

https://codereview.chromium.org/2894863002/diff/20001/net/nqe/network_qualiti...
net/nqe/network_qualities_prefs_manager.cc:112: void
NetworkQualitiesPrefsManager::ShutdownOnPrefThread() {
OnPrefSequence

https://codereview.chromium.org/2894863002/diff/20001/net/nqe/network_qualiti...
net/nqe/network_qualities_prefs_manager.cc:125: void
NetworkQualitiesPrefsManager::OnChangeInCachedNetworkQualityOnPrefThread(
OnPrefSequence

[Yeol Park, 2017-05-23 05:19:14]

The CQ bit was checked by peary2@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 05:19:30]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yeol Park, 2017-05-23 05:26:33]

Thank you for your feedback. :)

https://codereview.chromium.org/2894863002/diff/20001/net/base/directory_list...
File net/base/directory_lister.cc (right):

https://codereview.chromium.org/2894863002/diff/20001/net/base/directory_list...
net/base/directory_lister.cc:106: void
DirectoryLister::Core::CancelOnOriginThread() {
On 2017/05/22 17:22:13, Ryan Sleevi wrote:
> CancelOnOriginSequence ?

Done.

https://codereview.chromium.org/2894863002/diff/20001/net/base/directory_list...
net/base/directory_lister.cc:176: void
DirectoryLister::Core::DoneOnOriginThread(
On 2017/05/22 17:22:13, Ryan Sleevi wrote:
> DoneOnOriginSequence

Done.

https://codereview.chromium.org/2894863002/diff/20001/net/cert_net/cert_net_f...
File net/cert_net/cert_net_fetcher_impl.cc (right):

https://codereview.chromium.org/2894863002/diff/20001/net/cert_net/cert_net_f...
net/cert_net/cert_net_fetcher_impl.cc:772: void
DoFetchOnNetworkThread(std::unique_ptr<RequestParams> request_params,
On 2017/05/22 17:22:13, Ryan Sleevi wrote:
> DoFetchOnNetworkSequence

Done.

https://codereview.chromium.org/2894863002/diff/20001/net/http/http_server_pr...
File net/http/http_server_properties_manager.cc (right):

https://codereview.chromium.org/2894863002/diff/20001/net/http/http_server_pr...
net/http/http_server_properties_manager.cc:101: void
HttpServerPropertiesManager::InitializeOnNetworkThread() {
On 2017/05/22 17:22:13, Ryan Sleevi wrote:
> OnNetworkSequence?

Done.

https://codereview.chromium.org/2894863002/diff/20001/net/http/http_server_pr...
net/http/http_server_properties_manager.cc:121: void
HttpServerPropertiesManager::ShutdownOnPrefThread() {
On 2017/05/22 17:22:13, Ryan Sleevi wrote:
> OnPrefSequence?

Done.

https://codereview.chromium.org/2894863002/diff/20001/net/http/http_server_pr...
net/http/http_server_properties_manager.cc:393: void
HttpServerPropertiesManager::ScheduleUpdateCacheOnPrefThread() {
On 2017/05/22 17:22:13, Ryan Sleevi wrote:
> OnPrefSequence

Done.

https://codereview.chromium.org/2894863002/diff/20001/net/http/http_server_pr...
net/http/http_server_properties_manager.cc:404: void
HttpServerPropertiesManager::UpdateCacheFromPrefsOnPrefThread() {
On 2017/05/22 17:22:13, Ryan Sleevi wrote:
> OnPrefSequence

Done.

https://codereview.chromium.org/2894863002/diff/20001/net/http/http_server_pr...
net/http/http_server_properties_manager.cc:774: void
HttpServerPropertiesManager::UpdateCacheFromPrefsOnNetworkThread(
On 2017/05/22 17:22:13, Ryan Sleevi wrote:
> OnNetworkSequence

Done.

https://codereview.chromium.org/2894863002/diff/20001/net/http/http_server_pr...
net/http/http_server_properties_manager.cc:833: void
HttpServerPropertiesManager::UpdatePrefsFromCacheOnNetworkThread(
On 2017/05/22 17:22:14, Ryan Sleevi wrote:
> OnNetworkSequence

Done.

https://codereview.chromium.org/2894863002/diff/20001/net/nqe/network_qualiti...
File net/nqe/network_qualities_prefs_manager.cc (right):

https://codereview.chromium.org/2894863002/diff/20001/net/nqe/network_qualiti...
net/nqe/network_qualities_prefs_manager.cc:112: void
NetworkQualitiesPrefsManager::ShutdownOnPrefThread() {
On 2017/05/22 17:22:14, Ryan Sleevi wrote:
> OnPrefSequence

Done.

https://codereview.chromium.org/2894863002/diff/20001/net/nqe/network_qualiti...
net/nqe/network_qualities_prefs_manager.cc:125: void
NetworkQualitiesPrefsManager::OnChangeInCachedNetworkQualityOnPrefThread(
On 2017/05/22 17:22:14, Ryan Sleevi wrote:
> OnPrefSequence

Done.

[Yeol Park, 2017-05-23 05:27:22]

https://codereview.chromium.org/2894863002/diff/20001/net/http/http_server_pr...
File net/http/http_server_properties_manager.cc (right):

https://codereview.chromium.org/2894863002/diff/20001/net/http/http_server_pr...
net/http/http_server_properties_manager.cc:812: void
HttpServerPropertiesManager::ScheduleUpdatePrefsOnNetworkThread(
On 2017/05/22 17:22:13, Ryan Sleevi wrote:
> OnNetworkSequence

Done.

[Yeol Park, 2017-05-23 05:28:22]

peary2@gmail.com changed reviewers:
+ jochen@chromium.org

[Yeol Park, 2017-05-23 05:28:43]

PTAL :)

+jochen@ for chrome/*

[commit-bot: I haz the power, 2017-05-23 05:28:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 05:28:59]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[Yeol Park, 2017-05-23 07:49:36]

Description was changed from

==========
Rename TaskRunner::RunsTasksOnCurrentThread() in //net

renamed TaskRunner::RunsTasksOnCurrentThread() to
TaskRunner::RunsTasksInCurrentSequence() in //net

BUG=665062
==========

to

==========
Rename TaskRunner::RunsTasksOnCurrentThread() in //net

renamed TaskRunner::RunsTasksOnCurrentThread() to
TaskRunner::RunsTasksInCurrentSequence() in //net

BUG=665062
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[Yeol Park, 2017-05-23 07:50:13]

The CQ bit was checked by peary2@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 07:50:34]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 09:25:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 09:25:15]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2017-05-23 11:08:39]

lgtm

[Yeol Park, 2017-06-01 02:06:22]

The CQ bit was checked by peary2@gmail.com

[Yeol Park, 2017-06-01 02:06:22]

The patchset sent to the CQ was uploaded after l-g-t-m from rsleevi@chromium.org
Link to the patchset: https://codereview.chromium.org/2894863002/#ps60001
(title: "fixed build error")

[commit-bot: I haz the power, 2017-06-01 02:06:48]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-01 04:11:20]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1496282782211080,
"parent_rev": "5cb31a1c6f558ac77ff4f2ef20dab5899428aa46", "commit_rev":
"aeac7780cf8392c00b9179fd09aed830fe9fbe22"}

[commit-bot: I haz the power, 2017-06-01 04:11:28]

Description was changed from

==========
Rename TaskRunner::RunsTasksOnCurrentThread() in //net

renamed TaskRunner::RunsTasksOnCurrentThread() to
TaskRunner::RunsTasksInCurrentSequence() in //net

BUG=665062
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
Rename TaskRunner::RunsTasksOnCurrentThread() in //net

renamed TaskRunner::RunsTasksOnCurrentThread() to
TaskRunner::RunsTasksInCurrentSequence() in //net

BUG=665062
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2894863002
Cr-Commit-Position: refs/heads/master@{#476185}
Committed:
https://chromium.googlesource.com/chromium/src/+/aeac7780cf8392c00b9179fd09ae...
==========

[commit-bot: I haz the power, 2017-06-01 04:11:29]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/aeac7780cf8392c00b9179fd09ae...