Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2894823002: Clean up blink::FrameView::ForceLayoutForPagination().

Created:
3 years, 7 months ago by Lei Zhang
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews, blink-reviews, blink-reviews-frames_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up blink::FrameView::ForceLayoutForPagination().

Patch Set 1 : add helper method #

Patch Set 2 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -81 lines) Patch
M third_party/WebKit/Source/core/frame/FrameView.h View 2 chunks +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 1 chunk +88 lines, -80 lines 0 comments Download

Messages

Total messages: 4 (4 generated)
Lei Zhang
The CQ bit was checked by thestig@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-19 08:00:39 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2894823002/20001
3 years, 7 months ago (2017-05-19 08:01:03 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-19 09:57:16 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-19 09:57:17 UTC) #4 
Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

Powered by Google App Engine
This is Rietveld 408576698