Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Issue 2894803002: Use current selection when tab navigation. (Closed)

Created:
3 years, 7 months ago by yoichio
Modified:
3 years, 7 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use current selection when tab navigation. This CL lets FrameSelection::RevealSelection() use VisibleUnits::ComputeTextRect() to compute current selection range instead of LayoutSelection::Bounds() of last selection range. VisibleUnits.cpp::ComputeTextRect(): templatize to define flat tree version. BUG=712986 Review-Url: https://codereview.chromium.org/2894803002 Cr-Commit-Position: refs/heads/master@{#473546} Committed: https://chromium.googlesource.com/chromium/src/+/3638f51b033ad950d63f9186f7d0329a4eed48c9

Patch Set 1 : update #

Total comments: 2

Patch Set 2 : Fix selection direction #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -10 lines) Patch
A third_party/WebKit/LayoutTests/editing/input/scroll-with-tab-to-input-regression.html View 1 chunk +27 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelection.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelection.cpp View 1 2 chunks +12 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleUnits.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleUnits.cpp View 2 chunks +17 lines, -6 lines 0 comments Download

Messages

Total messages: 25 (19 generated)
yoichio
3 years, 7 months ago (2017-05-22 07:10:46 UTC) #13
yosin_UTC9
https://codereview.chromium.org/2894803002/diff/40001/third_party/WebKit/Source/core/editing/FrameSelection.cpp File third_party/WebKit/Source/core/editing/FrameSelection.cpp (right): https://codereview.chromium.org/2894803002/diff/40001/third_party/WebKit/Source/core/editing/FrameSelection.cpp#newcode956 third_party/WebKit/Source/core/editing/FrameSelection.cpp:956: EphemeralRangeInFlatTree(selection.Base(), selection.Extent())); I think we should use VSInFlatTree.Start() and ...
3 years, 7 months ago (2017-05-22 08:11:43 UTC) #14
yoichio
PTAL https://codereview.chromium.org/2894803002/diff/40001/third_party/WebKit/Source/core/editing/FrameSelection.cpp File third_party/WebKit/Source/core/editing/FrameSelection.cpp (right): https://codereview.chromium.org/2894803002/diff/40001/third_party/WebKit/Source/core/editing/FrameSelection.cpp#newcode956 third_party/WebKit/Source/core/editing/FrameSelection.cpp:956: EphemeralRangeInFlatTree(selection.Base(), selection.Extent())); On 2017/05/22 08:11:43, yosin_UTC9 wrote: > ...
3 years, 7 months ago (2017-05-22 08:42:21 UTC) #17
yosin_UTC9
lgtm
3 years, 7 months ago (2017-05-22 08:45:20 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2894803002/80001
3 years, 7 months ago (2017-05-22 08:45:26 UTC) #22
commit-bot: I haz the power
3 years, 7 months ago (2017-05-22 10:52:17 UTC) #25
Message was sent while issue was closed.
Committed patchset #2 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/3638f51b033ad950d63f9186f7d0...

Powered by Google App Engine
This is Rietveld 408576698