[MD settings] remove unwanted separator line

[MD settings] remove unwanted separator line

This CL removes a grey separator line in the ChromeOS network settings.

BUG=723150
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2894773002
Cr-Commit-Position: refs/heads/master@{#474109}
Committed: https://chromium.googlesource.com/chromium/src/+/a9822cebdf63992f0ae013f524bc1f34ab3cf148

[dschuyler, 2017-05-19 00:19:11]

Description was changed from

==========
[MD settings] remove unwanted separator line

This CL removes a grey separator line in the ChromeOS network settings.

BUG=723150
==========

to

==========
[MD settings] remove unwanted separator line

This CL removes a grey separator line in the ChromeOS network settings.

BUG=723150
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dschuyler, 2017-05-19 00:19:14]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[dschuyler, 2017-05-19 00:20:01]

dschuyler@chromium.org changed reviewers:
+ stevenjb@chromium.org

[commit-bot: I haz the power, 2017-05-19 00:21:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 03:12:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 03:12:31]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[stevenjb, 2017-05-19 16:56:59]

https://codereview.chromium.org/2894773002/diff/1/ui/webui/resources/cr_eleme...
File ui/webui/resources/cr_elements/network/cr_network_list_item.html (left):

https://codereview.chromium.org/2894773002/diff/1/ui/webui/resources/cr_eleme...
ui/webui/resources/cr_elements/network/cr_network_list_item.html:55: }
Do we not need this to flip the button direction in rtl?

[dschuyler, 2017-05-23 01:23:39]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 01:24:08]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2017-05-23 01:24:55]

https://codereview.chromium.org/2894773002/diff/1/ui/webui/resources/cr_eleme...
File ui/webui/resources/cr_elements/network/cr_network_list_item.html (left):

https://codereview.chromium.org/2894773002/diff/1/ui/webui/resources/cr_eleme...
ui/webui/resources/cr_elements/network/cr_network_list_item.html:55: }
On 2017/05/19 16:56:58, stevenjb wrote:
> Do we not need this to flip the button direction in rtl?

I'd like to address that by moving the mirroring from settings_shared_css up to
cr_elements/shared_style_css

done.

https://codereview.chromium.org/2894773002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_page/settings_subpage.html
(right):

https://codereview.chromium.org/2894773002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/settings_page/settings_subpage.html:22:
:host-context([dir=rtl]) paper-icon-button[icon='settings:arrow-back'] {
This is the only place settings:arrow-back is used, so I move this mirroring
here.

https://codereview.chromium.org/2894773002/diff/20001/ui/webui/resources/cr_e...
File ui/webui/resources/cr_elements/shared_style_css.html (right):

https://codereview.chromium.org/2894773002/diff/20001/ui/webui/resources/cr_e...
ui/webui/resources/cr_elements/shared_style_css.html:12: }
Moved here from settings_shared_css.html

[commit-bot: I haz the power, 2017-05-23 02:41:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 02:41:07]

Dry run: This issue passed the CQ dry run.

[stevenjb, 2017-05-23 19:13:57]

lgtm

[dschuyler, 2017-05-23 19:17:23]

The CQ bit was checked by dschuyler@chromium.org

[commit-bot: I haz the power, 2017-05-23 19:17:55]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 19:34:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 19:34:12]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dschuyler, 2017-05-23 23:32:51]

The CQ bit was checked by dschuyler@chromium.org

[commit-bot: I haz the power, 2017-05-23 23:35:17]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 23:48:32]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495582371881210,
"parent_rev": "fd24fc9f7417c5e9a580911faa80a7c75938c004", "commit_rev":
"a9822cebdf63992f0ae013f524bc1f34ab3cf148"}

[commit-bot: I haz the power, 2017-05-23 23:48:49]

Description was changed from

==========
[MD settings] remove unwanted separator line

This CL removes a grey separator line in the ChromeOS network settings.

BUG=723150
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD settings] remove unwanted separator line

This CL removes a grey separator line in the ChromeOS network settings.

BUG=723150
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2894773002
Cr-Commit-Position: refs/heads/master@{#474109}
Committed:
https://chromium.googlesource.com/chromium/src/+/a9822cebdf63992f0ae013f524bc...
==========

[commit-bot: I haz the power, 2017-05-23 23:48:52]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a9822cebdf63992f0ae013f524bc...