Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(680)

Issue 2894763003: Updates display.mojom to include more of Display (Closed)

Created:
3 years, 7 months ago by sky
Modified:
3 years, 7 months ago
Reviewers:
Tom Sepez
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Updates display.mojom to include more of Display There were a couple of values not being written. This updates the mojom and traits appropriately. BUG=718860 TEST=covered by tests R=tsepez@chromium.org Review-Url: https://codereview.chromium.org/2894763003 Cr-Commit-Position: refs/heads/master@{#473473} Committed: https://chromium.googlesource.com/chromium/src/+/97853258c546808df7ba51746b878ee8294a72a6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -0 lines) Patch
M ui/display/mojo/display.mojom View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/display/mojo/display_struct_traits.h View 2 chunks +16 lines, -0 lines 0 comments Download
M ui/display/mojo/display_struct_traits.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M ui/display/mojo/display_struct_traits_unittest.cc View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
sky
3 years, 7 months ago (2017-05-19 22:56:40 UTC) #1
Tom Sepez
lgtm
3 years, 7 months ago (2017-05-19 23:16:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2894763003/1
3 years, 7 months ago (2017-05-19 23:19:47 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/298810)
3 years, 7 months ago (2017-05-20 03:43:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2894763003/1
3 years, 7 months ago (2017-05-21 14:30:57 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-21 15:32:11 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/97853258c546808df7ba51746b87...

Powered by Google App Engine
This is Rietveld 408576698