Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 2894733002: Kill ScrollbarModesCalculationStrategy. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months, 1 week ago by skobes
Modified:
4 months, 1 week ago
Reviewers:
szager1
CC:
chromium-reviews, blink-reviews, blink-reviews-frames_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Kill ScrollbarModesCalculationStrategy. This was added in http://crrev.com/9de09a32, but I don't think it makes sense anymore. Its purpose is to include child frames in FV::scrollable_areas_ even if their scrollbars have been suppressed by FV::SetCanHaveScrollbars(false). But such frames are not scrollable by user input (see FV::UserInputScrollable which examines the ScrollbarMode values), so there is no need for them to be in FV::scrollable_areas_. BUG=724309 Review-Url: https://codereview.chromium.org/2894733002 Cr-Commit-Position: refs/heads/master@{#473100} Committed: https://chromium.googlesource.com/chromium/src/+/6130f3dd3af923ec847c32372351495d5b8878fd

Patch Set 1 #

Messages

Total messages: 15 (11 generated)
skobes
4 months, 1 week ago (2017-05-19 00:52:06 UTC) #8
szager1
lgtm
4 months, 1 week ago (2017-05-19 03:29:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2894733002/20001
4 months, 1 week ago (2017-05-19 03:34:56 UTC) #12
commit-bot: I haz the power
4 months, 1 week ago (2017-05-19 05:46:43 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6130f3dd3af923ec847c32372351...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld b40b6558b