cc/layers/scrollbar_layer_impl_base.h - Issue 2894673008: Refactor scrollbar maps from multimap & std::set to simpler flat_{map, set}

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/layers/scrollbar_layer_impl_base.h

Issue 2894673008: Refactor scrollbar maps from multimap & std::set to simpler flat_{map, set} (Closed)

Patch Set: Update per reviewer comments Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/layers/scrollbar_layer_impl_base.h

diff --git a/cc/layers/scrollbar_layer_impl_base.h b/cc/layers/scrollbar_layer_impl_base.h

index d5bc0f8be412b6af942f84ae011b29c4f0917818..94be78e949ad34fd1fa45878e3fdd81b49decb53 100644

--- a/cc/layers/scrollbar_layer_impl_base.h

+++ b/cc/layers/scrollbar_layer_impl_base.h

@@ -96,7 +96,7 @@ class CC_EXPORT ScrollbarLayerImplBase : public LayerImpl {

DISALLOW_COPY_AND_ASSIGN(ScrollbarLayerImplBase);

};

-typedef std::set<ScrollbarLayerImplBase*> ScrollbarSet;

+using ScrollbarSet = base::flat_set<ScrollbarLayerImplBase*>;

vmpstr 2017/05/22 16:27:22 nit: Include flat_set plz.

pdr. 2017/05/22 16:43:48 Done

} // namespace cc

« no previous file with comments | « no previous file | cc/trees/layer_tree_impl.h » ('j') | cc/trees/layer_tree_impl.cc » ('J')