cc/layers/scrollbar_layer_impl_base.h - Issue 2894673008: Refactor scrollbar maps from multimap & std::set to simpler flat_{map, set}

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: cc/layers/scrollbar_layer_impl_base.h

Issue 2894673008: Refactor scrollbar maps from multimap & std::set to simpler flat_{map, set} (Closed)

Patch Set: Update per reviewer comments Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | cc/trees/layer_tree_impl.h » ('j') | cc/trees/layer_tree_impl.cc » ('J')

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CC_LAYERS_SCROLLBAR_LAYER_IMPL_BASE_H_	5 #ifndef CC_LAYERS_SCROLLBAR_LAYER_IMPL_BASE_H_

6 #define CC_LAYERS_SCROLLBAR_LAYER_IMPL_BASE_H_	6 #define CC_LAYERS_SCROLLBAR_LAYER_IMPL_BASE_H_

7	7

8 #include "base/macros.h"	8 #include "base/macros.h"

9 #include "cc/cc_export.h"	9 #include "cc/cc_export.h"

10 #include "cc/input/scrollbar.h"	10 #include "cc/input/scrollbar.h"

(...skipping 78 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
89 ScrollbarOrientation orientation_;	89 ScrollbarOrientation orientation_;

90 bool is_left_side_vertical_scrollbar_;	90 bool is_left_side_vertical_scrollbar_;

91	91

92 // Difference between the clip layer's height and the visible viewport	92 // Difference between the clip layer's height and the visible viewport

93 // height (which may differ in the presence of top-controls hiding).	93 // height (which may differ in the presence of top-controls hiding).

94 float vertical_adjust_;	94 float vertical_adjust_;

95	95

96 DISALLOW_COPY_AND_ASSIGN(ScrollbarLayerImplBase);	96 DISALLOW_COPY_AND_ASSIGN(ScrollbarLayerImplBase);

97 };	97 };

98	98

99 typedef std::set<ScrollbarLayerImplBase*> ScrollbarSet;	99 using ScrollbarSet = base::flat_set<ScrollbarLayerImplBase*>;
	vmpstr 2017/05/22 16:27:22 nit: Include flat_set plz. nit: Include flat_set plz. pdr. 2017/05/22 16:43:48 Done Show quoted text On 2017/05/22 at 16:27:22, vmpstr wrote: > nit: Include flat_set plz. Done
100	100

101 } // namespace cc	101 } // namespace cc

102	102

103 #endif // CC_LAYERS_SCROLLBAR_LAYER_IMPL_BASE_H_	103 #endif // CC_LAYERS_SCROLLBAR_LAYER_IMPL_BASE_H_

OLD	NEW