Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2894673007:
Update the text in the interstitial for PHA and MUwS on Android (Closed)
|
Created:
3 years, 7 months ago by vakh (use Gerrit instead) Modified:
3 years, 7 months ago CC:
chromium-reviews, kewang, srahim Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionUpdate the text in the interstitial for PHA and MUwS on Android
String changes only.
BUG=653651
Review-Url: https://codereview.chromium.org/2894673007
Cr-Commit-Position: refs/heads/master@{#473668}
Committed: https://chromium.googlesource.com/chromium/src/+/b47dcf1b6509900c843e4f43cc009baee598944a
Patch Set 1 #Patch Set 2 : rebase #
Total comments: 4
Patch Set 3 : Swap the message for IDS_MALWARE_V3_HEADING between android and !android since I got that wrong the… #Messages
Total messages: 22 (15 generated)
The CQ bit was checked by vakh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
vakh@chromium.org changed reviewers: + emilyschechter@chromium.org, nparker@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by vakh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Swap the message for IDS_MALWARE_V3_HEADING between android and !android since I got that wrong the first time.
The CQ bit was checked by vakh@chromium.org to run a CQ dry run
srahim@chromium.org changed reviewers: + srahim@chromium.org
https://codereview.chromium.org/2894673007/diff/20001/components/security_int... File components/security_interstitials_strings.grdp (right): https://codereview.chromium.org/2894673007/diff/20001/components/security_int... components/security_interstitials_strings.grdp:126: The site ahead contains malware I think the messages in 124-133 are reversed. The regular malware warning is "The site ahead contains malware" But for PHA on Android, the warning should say "The site ahead contains dangerous apps" https://codereview.chromium.org/2894673007/diff/20001/components/security_int... components/security_interstitials_strings.grdp:137: Attackers currently on <ph name="BEGIN_BOLD"><strong></ph><ph name="SITE">$1<ex>example.com</ex></ph><ph name="END_BOLD"></strong></ph> could install dangerous apps that damage your device, add hidden charges to your mobile bill, or steal your personal information. <ph name="BEGIN_LEARN_MORE_LINK"><a href="#" id="learn-more-link"></ph>Learn more<ph name="END_LEARN_MORE_LINK"></a></ph> LGTM
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2894673007/diff/20001/components/security_int... File components/security_interstitials_strings.grdp (right): https://codereview.chromium.org/2894673007/diff/20001/components/security_int... components/security_interstitials_strings.grdp:126: The site ahead contains malware On 2017/05/19 22:43:53, srahim wrote: > I think the messages in 124-133 are reversed. > > The regular malware warning is "The site ahead contains malware" > But for PHA on Android, the warning should say "The site ahead contains > dangerous apps" Done. Good catch. https://codereview.chromium.org/2894673007/diff/20001/components/security_int... components/security_interstitials_strings.grdp:137: Attackers currently on <ph name="BEGIN_BOLD"><strong></ph><ph name="SITE">$1<ex>example.com</ex></ph><ph name="END_BOLD"></strong></ph> could install dangerous apps that damage your device, add hidden charges to your mobile bill, or steal your personal information. <ph name="BEGIN_LEARN_MORE_LINK"><a href="#" id="learn-more-link"></ph>Learn more<ph name="END_LEARN_MORE_LINK"></a></ph> On 2017/05/19 22:43:53, srahim wrote: > LGTM Acknowledged.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by vakh@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 2, "attempt_start_ts": 1495482731023860, "parent_rev":
"c28017fd850d3035cdfc11d688e07331d1e577fe", "commit_rev":
"b47dcf1b6509900c843e4f43cc009baee598944a"}
Message was sent while issue was closed.
Description was changed from ========== Update the text in the interstitial for PHA and MUwS on Android String changes only. BUG=653651 ========== to ========== Update the text in the interstitial for PHA and MUwS on Android String changes only. BUG=653651 Review-Url: https://codereview.chromium.org/2894673007 Cr-Commit-Position: refs/heads/master@{#473668} Committed: https://chromium.googlesource.com/chromium/src/+/b47dcf1b6509900c843e4f43cc00... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:2) as https://chromium.googlesource.com/chromium/src/+/b47dcf1b6509900c843e4f43cc00... |
