Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 2894673006: Deletes chrome/app/address_input_strings.grdp (Closed)

Created:
3 years, 7 months ago by Moe
Modified:
3 years, 7 months ago
Reviewers:
grt (UTC plus 2)
CC:
chromium-reviews, please use gerrit instead
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Deletes chrome/app/address_input_strings.grdp and relevant entries in OWNERS file. address_input_strings.grd and the translation were moved to third_party/libaddressinput/chromium/ in: https://codereview.chromium.org/2886173002/ BUG=672458 Review-Url: https://codereview.chromium.org/2894673006 Cr-Commit-Position: refs/heads/master@{#473702} Committed: https://chromium.googlesource.com/chromium/src/+/27d00a1cc8265350d09f7eb9b434b0640de931ca

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -313 lines) Patch
M chrome/app/OWNERS View 1 chunk +0 lines, -3 lines 0 comments Download
D chrome/app/address_input_strings.grdp View 1 chunk +0 lines, -310 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
Moe
Hi Greg, Please take a look.
3 years, 7 months ago (2017-05-19 17:17:28 UTC) #3
grt (UTC plus 2)
is there any reason for the translations in chrome/app/resources to stay around?
3 years, 7 months ago (2017-05-22 10:03:11 UTC) #8
Moe
On 2017/05/22 10:03:11, grt (UTC plus 2) wrote: > is there any reason for the ...
3 years, 7 months ago (2017-05-22 15:23:34 UTC) #9
grt (UTC plus 2)
i looked for the xtb files in my out-of-date checkout and didn't notice that you'd ...
3 years, 7 months ago (2017-05-22 19:17:23 UTC) #11
Moe
On 2017/05/22 19:17:23, grt (UTC plus 2) wrote: > i looked for the xtb files ...
3 years, 7 months ago (2017-05-22 21:16:42 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2894673006/1
3 years, 7 months ago (2017-05-22 21:17:14 UTC) #14
commit-bot: I haz the power
3 years, 7 months ago (2017-05-22 21:29:30 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/27d00a1cc8265350d09f7eb9b434...

Powered by Google App Engine
This is Rietveld 408576698