Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(491)

Issue 2894653002: [ObjC ARC] Converts ios/chrome/browser/metrics:unit_tests_internal to ARC. (Closed)

Created:
1 year, 1 month ago by lindsayw
Modified:
1 year ago
Reviewers:
stkhapugin, lpromero
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, asvitkine+watch_chromium.org, marq+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/metrics:unit_tests_internal to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2894653002 Cr-Commit-Position: refs/heads/master@{#475331} Committed: https://chromium.googlesource.com/chromium/src/+/515ce76a623d1521ded07bc95f4dde90486b2012

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -31 lines) Patch
M ios/chrome/browser/metrics/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/metrics/size_class_recorder_unittest.mm View 13 chunks +30 lines, -27 lines 0 comments Download
M ios/chrome/browser/metrics/tab_usage_recorder_unittest.mm View 4 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 22 (17 generated)
lindsayw
Thanks for the review!
1 year ago (2017-05-22 16:32:23 UTC) #14
lindsayw
lpromero@chromium.org: Please review for Owners. No rush I know Paris is out, so whenever you ...
1 year ago (2017-05-25 14:30:32 UTC) #16
lpromero
lgtm
1 year ago (2017-05-29 09:47:02 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2894653002/1
1 year ago (2017-05-29 09:47:15 UTC) #19
commit-bot: I haz the power
1 year ago (2017-05-29 10:45:25 UTC) #22
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/515ce76a623d1521ded07bc95f4d...

Powered by Google App Engine
This is Rietveld 408576698