Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(13)

Issue 2894623004: [ObjC ARC] Converts ios/chrome/browser/voice:voice to ARC.

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 3 days ago by lindsayw
Modified:
3 days, 8 hours ago
Reviewers:
kkhorimoto_
CC:
chromium-reviews, marq+watch_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org, pkl -pls.ping.after.24h.
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/voice:voice to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None

Patch Set 1 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -12 lines) Patch
M ios/chrome/browser/voice/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/voice/speech_input_locale_config.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/voice/speech_input_locale_config_impl.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/voice/speech_input_locale_match_config.mm View 6 chunks +15 lines, -12 lines 6 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 12 (8 generated)
lindsayw
Thanks for the review!
1 week, 2 days ago (2017-05-19 12:05:51 UTC) #6
lindsayw
Thanks for the review!
5 days, 9 hours ago (2017-05-23 18:55:24 UTC) #7
lindsayw
kkhorimoto@chromium.org: Please review changes in Hi Kurt, Do you mind reviewing since Paris is out? ...
3 days, 13 hours ago (2017-05-25 14:28:57 UTC) #9
kkhorimoto_
3 days, 8 hours ago (2017-05-25 19:07:37 UTC) #12
https://codereview.chromium.org/2894623004/diff/1/ios/chrome/browser/voice/sp...
File ios/chrome/browser/voice/speech_input_locale_match_config.mm (right):

https://codereview.chromium.org/2894623004/diff/1/ios/chrome/browser/voice/sp...
ios/chrome/browser/voice/speech_input_locale_match_config.mm:27: }
This whole block within the curly braces can be removed since we can just
synthesize the variable now.

https://codereview.chromium.org/2894623004/diff/1/ios/chrome/browser/voice/sp...
ios/chrome/browser/voice/speech_input_locale_match_config.mm:35: 
Can you synthesize the property here?

@synthesize matches = _matches;

https://codereview.chromium.org/2894623004/diff/1/ios/chrome/browser/voice/sp...
ios/chrome/browser/voice/speech_input_locale_match_config.mm:57: }
This will also be handled by property synthesis

https://codereview.chromium.org/2894623004/diff/1/ios/chrome/browser/voice/sp...
ios/chrome/browser/voice/speech_input_locale_match_config.mm:87: @end
This whole @interface section can be removed if you synthesize the properties.

https://codereview.chromium.org/2894623004/diff/1/ios/chrome/browser/voice/sp...
ios/chrome/browser/voice/speech_input_locale_match_config.mm:90: 
@synthesize matchedLocaleCode = _matchedLocaleCode;
@synthesize matchingLocaleCodes = _matchingLocaleCodes;
@synthesize matchingLanguages = _matchingLanguages;

https://codereview.chromium.org/2894623004/diff/1/ios/chrome/browser/voice/sp...
ios/chrome/browser/voice/speech_input_locale_match_config.mm:112: }
All three of these can be removed.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 650457f06