Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2894623002: [Media Router] Add UMA metrics for media route controller creation (Closed)

Created:
3 years, 7 months ago by takumif
Modified:
3 years, 7 months ago
CC:
Aaron Boodman, abarth-chromium, asvitkine+watch_chromium.org, chfremer+watch_chromium.org, chromium-reviews, darin (slow to review), feature-media-reviews_chromium.org, imcheng+watch_chromium.org, mfoltz+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Router] Add UMA metrics for media route controller creation This CL Adds an UMA metric to record the outcome whenever the Media Route Provider attempts to create a media route controller. BUG=707326 Review-Url: https://codereview.chromium.org/2894623002 Cr-Commit-Position: refs/heads/master@{#473732} Committed: https://chromium.googlesource.com/chromium/src/+/7cdd1a97517a87e7423d1638b72c439c48aa6435

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -1 line) Patch
M chrome/browser/media/router/mojo/media_router_mojo_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/router/mojo/media_router_mojo_metrics.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/media/router/mojo/media_router_mojo_metrics.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
takumif
Please take a look at: mfoltz: everything asvitkine: histograms.xml Thanks!
3 years, 7 months ago (2017-05-18 19:07:26 UTC) #4
Alexei Svitkine (slow)
lgtm
3 years, 7 months ago (2017-05-19 20:17:59 UTC) #5
mark a. foltz
lgtm
3 years, 7 months ago (2017-05-22 18:10:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2894623002/1
3 years, 7 months ago (2017-05-22 23:00:15 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-05-22 23:06:29 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7cdd1a97517a87e7423d1638b72c...

Powered by Google App Engine
This is Rietveld 408576698