Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 2894573005: Check Null view in LayoutObjectChildList::InvalidatePaintOnRemoval() (Closed)

Created:
3 years, 7 months ago by Xianzhu
Modified:
3 years, 7 months ago
Reviewers:
chrishtr, pdr.
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Check Null view in LayoutObjectChildList::InvalidatePaintOnRemoval() BUG=720931 Review-Url: https://codereview.chromium.org/2894573005 Cr-Commit-Position: refs/heads/master@{#473289} Committed: https://chromium.googlesource.com/chromium/src/+/5fd6f48cdf820ae818d98d71a4ea60cb36245264

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/layout/LayoutObjectChildList.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
Xianzhu
The crash stacks clearly show that the LayoutView is null. Not sure why a LayoutObject ...
3 years, 7 months ago (2017-05-19 15:42:34 UTC) #4
pdr.
LGTM Just FYI, Chris is out on vacation today and next week.
3 years, 7 months ago (2017-05-19 16:58:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2894573005/1
3 years, 7 months ago (2017-05-19 17:08:18 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-19 19:51:15 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5fd6f48cdf820ae818d98d71a4ea...

Powered by Google App Engine
This is Rietveld 408576698