No extra space emission in TextIterator::HandleTextNode

No extra space emission in TextIterator::HandleTextNode

Due to historical reasons, TextIterator emits an extra space before a text node
with "white-space: pre" style if the last text node contains only collapsed
whitespaces. This might be a workaround for some other buggy behavior, which
no longer exists today.

Hence, this patch removes the extra space emission.

BUG=721957
Review-Url: https://codereview.chromium.org/2894543002
Cr-Commit-Position: refs/heads/master@{#473072}
Committed: https://chromium.googlesource.com/chromium/src/+/9b781c354432f97658390c848359d2d70ceb1cb5

[Xiaocheng, 2017-05-18 03:47:51]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-18 03:49:19]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 04:05:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 04:05:46]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Xiaocheng, 2017-05-18 07:12:53]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-18 07:13:15]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 08:19:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 08:19:30]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Xiaocheng, 2017-05-18 22:41:29]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-18 22:43:09]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2017-05-18 22:45:57]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-18 22:48:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2017-05-19 00:25:32]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 00:26:55]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2017-05-19 01:29:33]

xiaochengh@chromium.org changed reviewers:
+ yosin@chromium.org

[Xiaocheng, 2017-05-19 01:29:34]

I don't think the extra space emission is necessary. I haven't found any case
where we actually need a space emitted here. While a lot of layout tests are
affected, none of them is actually testing against this extra space.

Instead, we have seen cases where this line emits an unwanted space in
crbug.com/510335:

<div>
<span>foo </span> <span style="white-space:pre">bar</span>
</div>

div.innerText has two spaces between "foo" and "bar"

So I think this block should be removed.

WDYT?

[Xiaocheng, 2017-05-19 01:57:04]

Description was changed from

==========
EXPERIMENT No extra space emission in TextIterator::HandleTextNode

BUG=
==========

to

==========
EXPERIMENT No extra space emission in TextIterator::HandleTextNode

BUG=721957
==========

[Xiaocheng, 2017-05-19 02:05:00]

Description was changed from

==========
EXPERIMENT No extra space emission in TextIterator::HandleTextNode

BUG=721957
==========

to

==========
No extra space emission in TextIterator::HandleTextNode

Due to historical reasons, TextIterator emits an extra space before a text node
with "white-space: pre" style if the last text node contains only collapsed
whitespaces. This might be a workaround for some other buggy behavior, which
no longer exists today.

Hence, this patch removes the extra space emission.

BUG=721957
==========

[yosin_UTC9, 2017-05-19 02:09:43]

On 2017/05/19 at 01:29:34, xiaochengh wrote:
> I don't think the extra space emission is necessary. I haven't found any case
where we actually need a space emitted here. While a lot of layout tests are
affected, none of them is actually testing against this extra space.
> 
> Instead, we have seen cases where this line emits an unwanted space in
crbug.com/510335:
> 
> <div>
> <span>foo </span> <span style="white-space:pre">bar</span>
> </div>
> 
> div.innerText has two spaces between "foo" and "bar"
> 
> So I think this block should be removed.
> 
> WDYT?

We should have one space between "foo" and "bar".
It seems checking "white-space:pre" in next sibling when looking " " before it
is wrong.

[yosin_UTC9, 2017-05-19 02:10:09]

lgtm

Good catch!

[commit-bot: I haz the power, 2017-05-19 03:47:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 03:47:54]

Dry run: This issue passed the CQ dry run.

[xiaochengh, 2017-05-19 03:48:39]

The CQ bit was checked by xiaochengh@google.com

[commit-bot: I haz the power, 2017-05-19 03:49:46]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 03:56:15]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1495165719372510,
"parent_rev": "8cfa2b45fec4dbfe7edbdc32e114669f9640578e", "commit_rev":
"9b781c354432f97658390c848359d2d70ceb1cb5"}

[commit-bot: I haz the power, 2017-05-19 03:56:29]

Description was changed from

==========
No extra space emission in TextIterator::HandleTextNode

Due to historical reasons, TextIterator emits an extra space before a text node
with "white-space: pre" style if the last text node contains only collapsed
whitespaces. This might be a workaround for some other buggy behavior, which
no longer exists today.

Hence, this patch removes the extra space emission.

BUG=721957
==========

to

==========
No extra space emission in TextIterator::HandleTextNode

Due to historical reasons, TextIterator emits an extra space before a text node
with "white-space: pre" style if the last text node contains only collapsed
whitespaces. This might be a workaround for some other buggy behavior, which
no longer exists today.

Hence, this patch removes the extra space emission.

BUG=721957

Review-Url: https://codereview.chromium.org/2894543002
Cr-Commit-Position: refs/heads/master@{#473072}
Committed:
https://chromium.googlesource.com/chromium/src/+/9b781c354432f97658390c848359...
==========

[commit-bot: I haz the power, 2017-05-19 03:56:30]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/9b781c354432f97658390c848359...

[Xiaocheng, 2017-05-22 22:04:51]

A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/2896033003/ by xiaochengh@chromium.org.

The reason for reverting is: Breaking this case:

<div class=container id=div4 style="width:30px">
foooooooooooooooo

<span style="white-space: pre">bar</span>
</div>.