Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Issue 2894533003: [ObjC ARC] Converts ios/public/provider/chrome/browser:browser to ARC. (Closed)

Created:
3 years, 7 months ago by lindsayw
Modified:
3 years, 6 months ago
CC:
chromium-reviews, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/public/provider/chrome/browser:browser to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2894533003 Cr-Commit-Position: refs/heads/master@{#475621} Committed: https://chromium.googlesource.com/chromium/src/+/3efd1c325ae71905797d0fedc4e5cd22d8919ade

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M ios/public/provider/chrome/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/public/provider/chrome/browser/chrome_browser_provider.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/public/provider/chrome/browser/geolocation_updater_provider.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (16 generated)
lindsayw
Thanks for the review!
3 years, 7 months ago (2017-05-19 12:05:10 UTC) #10
lindsayw
HI Rohit, Can you please review since Paris is out and you are owner? Thanks,
3 years, 7 months ago (2017-05-25 14:35:08 UTC) #12
stkhapugin
lgtm
3 years, 6 months ago (2017-05-30 13:41:35 UTC) #16
rohitrao (ping after 24h)
lgtm
3 years, 6 months ago (2017-05-30 15:07:44 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2894533003/1
3 years, 6 months ago (2017-05-30 17:27:07 UTC) #19
commit-bot: I haz the power
3 years, 6 months ago (2017-05-30 19:11:55 UTC) #22
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3efd1c325ae71905797d0fedc4e5...

Powered by Google App Engine
This is Rietveld 408576698