Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 2894533002: Add a path to the generated Xcode workspace in the build document. (Closed)

Created:
3 years, 7 months ago by Hiroshi Ichikawa
Modified:
3 years, 7 months ago
Reviewers:
michaeldo
CC:
chromium-reviews, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a path to the generated Xcode workspace in the build document. It was a bit unclear to me where the workspace is. Review-Url: https://codereview.chromium.org/2894533002 Cr-Commit-Position: refs/heads/master@{#472689} Committed: https://chromium.googlesource.com/chromium/src/+/7c540a12a519f659e78e7d638aaab11c2d48cd20

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M docs/ios/build_instructions.md View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
Hiroshi Ichikawa
3 years, 7 months ago (2017-05-18 01:39:09 UTC) #2
michaeldo
LGTM Thank you for updating documentation! (Just FYI, you can TBR ios docs in the ...
3 years, 7 months ago (2017-05-18 05:30:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2894533002/1
3 years, 7 months ago (2017-05-18 05:32:28 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 05:50:49 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7c540a12a519f659e78e7d638aaa...

Powered by Google App Engine
This is Rietveld 408576698