Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2894523005: [turbofan] Add absolute upper bound for small function inlining. (Closed)

Created:
3 years, 7 months ago by Benedikt Meurer
Modified:
3 years, 7 months ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com, Michael Hablich
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Add absolute upper bound for small function inlining. Introduce a flag --max-inlined-nodes-absolute that is used to limit the number of nodes that we inline even in the presence of small function inlining, so that TurboFan graphs don't grow arbitrary large. BUG=chromium:724084, v8:6395, v8:6278, v8:6344, v8:6394 TBR=mvstanton@chromium.org Review-Url: https://codereview.chromium.org/2894523005 Cr-Commit-Position: refs/heads/master@{#45414} Committed: https://chromium.googlesource.com/v8/v8/+/d652d06f887b9ab062a0ab1bb697beef4a823a81

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M src/compiler/js-inlining-heuristic.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/flag-definitions.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Benedikt Meurer
3 years, 7 months ago (2017-05-19 03:49:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2894523005/1
3 years, 7 months ago (2017-05-19 03:50:25 UTC) #7
mvstanton
lgtm
3 years, 7 months ago (2017-05-19 04:06:01 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-19 04:26:02 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/d652d06f887b9ab062a0ab1bb697beef4a8...

Powered by Google App Engine
This is Rietveld 408576698