(false positive) Revert of Set render_frame_id while fetching from the dedicated worker ...

Revert of Set render_frame_id while fetching from the dedicated worker for off-main-thread-fetch (patchset #1 id:1 of https://codereview.chromium.org/2889603007/ )

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 472610 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzhiYjIyMTE0Y2ViOTk5YmY2MTM2NGI2YmY1NGMyMmRjOTczMDY1YTAM

Original issue's description:
> Set render_frame_id while fetching from the dedicated worker for off-main-thread-fetch
> 
> This ID is needed to show the TLS client auth prompts.
> 
> BUG=443374
> 
> Review-Url: https://codereview.chromium.org/2889603007
> Cr-Commit-Position: refs/heads/master@{#472610}
> Committed: https://chromium.googlesource.com/chromium/src/+/8bb22114ceb999bf61364b6bf54c22dc973065a0

TBR=kinuko@chromium.org,horo@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=443374

[findit-for-me, 2017-05-18 01:28:25]

Created Revert of Set render_frame_id while fetching from the dedicated worker
for off-main-thread-fetch

[findit-for-me, 2017-05-18 01:28:26]

findit-for-me@appspot.gserviceaccount.com changed reviewers:
+ dmazzoni@google.com, gab@google.com, kolos@google.com, peria@google.com

[findit-for-me, 2017-05-18 01:28:27]

Sheriffs:

Please confirm and "Quick L-G-T-M & CQ" this revert if it is correct.
If it is a false positive, please close it.

Findit (https://goo.gl/kROfz5) identified the original CL as the culprit
for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

[horo, 2017-05-18 01:53:10]

On 2017/05/18 01:28:27, findit-for-me wrote:
> Sheriffs:
> 
> Please confirm and "Quick L-G-T-M & CQ" this revert if it is correct.
> If it is a false positive, please close it.
> 
> Findit (https://goo.gl/kROfz5) identified the original CL as the culprit
> for failures in the build cycles as shown on:
>
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

Closing this CL, because zoom_bubble_view.cc is not related to this CL.

https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.chromiumos%2FCh...

../../chrome/browser/ui/views/location_bar/zoom_bubble_view.cc: In function
'std::unique_ptr<views::Button>
{anonymous}::CreateZoomButton(views::ButtonListener*, const gfx::VectorIcon&,
int)':
../../chrome/browser/ui/views/location_bar/zoom_bubble_view.cc:72:10: error:
cannot bind 'std::unique_ptr<views::ImageButton>' lvalue to
'std::unique_ptr<views::ImageButton>&&'
   return button;
          ^
In file included from
/b/c/b/ChromiumOS_x86_generic_Compile/.cros_cache/chrome-sdk/tarballs/x86-generic+9536.0.0+target_toolchain/usr/x86_64-pc-linux-gnu/i686-pc-linux-gnu/gcc-bin/4.9.x/../../../../lib/gcc/i686-pc-linux-gnu/4.9.x/include/g++-v4/memory:81:0,
                 from ../../base/timer/timer.h:52,
                 from
../../chrome/browser/ui/views/location_bar/zoom_bubble_view.h:10,
                 from
../../chrome/browser/ui/views/location_bar/zoom_bubble_view.cc:5:
/b/c/b/ChromiumOS_x86_generic_Compile/.cros_cache/chrome-sdk/tarballs/x86-generic+9536.0.0+target_toolchain/usr/x86_64-pc-linux-gnu/i686-pc-linux-gnu/gcc-bin/4.9.x/../../../../lib/gcc/i686-pc-linux-gnu/4.9.x/include/g++-v4/bits/unique_ptr.h:220:2:
note: initializing argument 1 of 'std::unique_ptr<_Tp,
_Dp>::unique_ptr(std::unique_ptr<_Up, _Ep>&&) [with _Up = views::ImageButton;
_Ep = std::default_delete<views::ImageButton>; <template-parameter-2-3> = void;
_Tp = views::Button; _Dp = std::default_delete<views::Button>]'
  unique_ptr(unique_ptr<_Up, _Ep>&& __u) noexcept
  ^
../../chrome/browser/ui/views/location_bar/zoom_bubble_view.cc:73:1: error:
control reaches end of non-void function [-Werror=return-type]
 }
 ^

[stgao, 2017-05-26 18:03:38]

Description was changed from

==========
Revert of Set render_frame_id while fetching from the dedicated worker for
off-main-thread-fetch (patchset #1 id:1 of
https://codereview.chromium.org/2889603007/ )

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 472610 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

Original issue's description:
> Set render_frame_id while fetching from the dedicated worker for
off-main-thread-fetch
> 
> This ID is needed to show the TLS client auth prompts.
> 
> BUG=443374
> 
> Review-Url: https://codereview.chromium.org/2889603007
> Cr-Commit-Position: refs/heads/master@{#472610}
> Committed:
https://chromium.googlesource.com/chromium/src/+/8bb22114ceb999bf61364b6bf54c...

TBR=kinuko@chromium.org,horo@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=443374
==========

to

==========
Revert of Set render_frame_id while fetching from the dedicated worker for
off-main-thread-fetch (patchset #1 id:1 of
https://codereview.chromium.org/2889603007/ )

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 472610 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

Original issue's description:
> Set render_frame_id while fetching from the dedicated worker for
off-main-thread-fetch
> 
> This ID is needed to show the TLS client auth prompts.
> 
> BUG=443374
> 
> Review-Url: https://codereview.chromium.org/2889603007
> Cr-Commit-Position: refs/heads/master@{#472610}
> Committed:
https://chromium.googlesource.com/chromium/src/+/8bb22114ceb999bf61364b6bf54c...

TBR=kinuko@chromium.org,horo@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=443374
==========

[stgao, 2017-05-26 18:11:26]

For record, this is a false positive due to flaky compile that failed "compile
confirm no-op".
The culprit is r472611 instead of this one r472610.

On 2017/05/18 01:53:10, horo wrote:
> On 2017/05/18 01:28:27, findit-for-me wrote:
> > Sheriffs:
> > 
> > Please confirm and "Quick L-G-T-M & CQ" this revert if it is correct.
> > If it is a false positive, please close it.
> > 
> > Findit (https://goo.gl/kROfz5) identified the original CL as the culprit
> > for failures in the build cycles as shown on:
> >
>
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...
> 
> Closing this CL, because zoom_bubble_view.cc is not related to this CL.
> 
>
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.chromiumos%2FCh...
> 
> ../../chrome/browser/ui/views/location_bar/zoom_bubble_view.cc: In function
> 'std::unique_ptr<views::Button>
> {anonymous}::CreateZoomButton(views::ButtonListener*, const gfx::VectorIcon&,
> int)':
> ../../chrome/browser/ui/views/location_bar/zoom_bubble_view.cc:72:10: error:
> cannot bind 'std::unique_ptr<views::ImageButton>' lvalue to
> 'std::unique_ptr<views::ImageButton>&&'
>    return button;
>           ^
> In file included from
>
/b/c/b/ChromiumOS_x86_generic_Compile/.cros_cache/chrome-sdk/tarballs/x86-generic+9536.0.0+target_toolchain/usr/x86_64-pc-linux-gnu/i686-pc-linux-gnu/gcc-bin/4.9.x/../../../../lib/gcc/i686-pc-linux-gnu/4.9.x/include/g++-v4/memory:81:0,
>                  from ../../base/timer/timer.h:52,
>                  from
> ../../chrome/browser/ui/views/location_bar/zoom_bubble_view.h:10,
>                  from
> ../../chrome/browser/ui/views/location_bar/zoom_bubble_view.cc:5:
>
/b/c/b/ChromiumOS_x86_generic_Compile/.cros_cache/chrome-sdk/tarballs/x86-generic+9536.0.0+target_toolchain/usr/x86_64-pc-linux-gnu/i686-pc-linux-gnu/gcc-bin/4.9.x/../../../../lib/gcc/i686-pc-linux-gnu/4.9.x/include/g++-v4/bits/unique_ptr.h:220:2:
> note: initializing argument 1 of 'std::unique_ptr<_Tp,
> _Dp>::unique_ptr(std::unique_ptr<_Up, _Ep>&&) [with _Up = views::ImageButton;
> _Ep = std::default_delete<views::ImageButton>; <template-parameter-2-3> =
void;
> _Tp = views::Button; _Dp = std::default_delete<views::Button>]'
>   unique_ptr(unique_ptr<_Up, _Ep>&& __u) noexcept
>   ^
> ../../chrome/browser/ui/views/location_bar/zoom_bubble_view.cc:73:1: error:
> control reaches end of non-void function [-Werror=return-type]
>  }
>  ^