Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issue 2889603007: Set render_frame_id while fetching from the dedicated worker for off-main-thread-fetch (Closed)

Created:
3 years, 7 months ago by horo
Modified:
3 years, 7 months ago
Reviewers:
kinuko
CC:
chromium-reviews, michaeln, mlamouri+watch-content_chromium.org, serviceworker-reviews, creis+watch_chromium.org, tzik, jsbell+serviceworker_chromium.org, nasko+codewatch_chromium.org, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+watch, shimazu+serviceworker_chromium.org, blink-worker-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Set render_frame_id while fetching from the dedicated worker for off-main-thread-fetch This ID is needed to show the TLS client auth prompts. BUG=443374 Review-Url: https://codereview.chromium.org/2889603007 Cr-Commit-Position: refs/heads/master@{#472610} Committed: https://chromium.googlesource.com/chromium/src/+/8bb22114ceb999bf61364b6bf54c22dc973065a0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -20 lines) Patch
M content/browser/shared_worker/worker_browsertest.cc View 9 chunks +51 lines, -10 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/service_worker/worker_fetch_context_impl.h View 3 chunks +3 lines, -0 lines 0 comments Download
M content/renderer/service_worker/worker_fetch_context_impl.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M content/test/data/workers/worker_common.js View 1 chunk +8 lines, -6 lines 0 comments Download
M content/test/data/workers/worker_tls_client_auth.html View 1 chunk +8 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
horo
kinuko@ Could you please review this?
3 years, 7 months ago (2017-05-17 07:24:44 UTC) #4
kinuko
lgtm
3 years, 7 months ago (2017-05-17 23:25:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2889603007/1
3 years, 7 months ago (2017-05-18 00:08:49 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/8bb22114ceb999bf61364b6bf54c22dc973065a0
3 years, 7 months ago (2017-05-18 00:16:59 UTC) #12
findit-for-me
3 years, 7 months ago (2017-05-18 01:28:25 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2894523002/ by
findit-for-me@appspot.gserviceaccount.com.

The reason for reverting is: 
Findit (https://goo.gl/kROfz5) identified CL at revision 472610 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb....

Powered by Google App Engine
This is Rietveld 408576698