Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1996)

Unified Diff: ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.mm

Issue 2894513002: Adding tools menu responsiveness metric. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.mm
diff --git a/ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.mm b/ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.mm
index e6bd95496bce10cbe3a5a71d22163a90f2dbbd75..4664b81b054d99021c03c3f7f5d707d5948c7f05 100644
--- a/ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.mm
+++ b/ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.mm
@@ -19,6 +19,7 @@
#include "ios/chrome/browser/ui/commands/ios_command_ids.h"
#import "ios/chrome/browser/ui/reading_list/reading_list_menu_notification_delegate.h"
#import "ios/chrome/browser/ui/reading_list/reading_list_menu_notifier.h"
+#import "ios/chrome/browser/ui/toolbar/toolbar_controller.h"
#import "ios/chrome/browser/ui/tools_menu/reading_list_menu_view_item.h"
#import "ios/chrome/browser/ui/tools_menu/tools_menu_constants.h"
#import "ios/chrome/browser/ui/tools_menu/tools_menu_model.h"
@@ -434,6 +435,11 @@ NS_INLINE void AnimateInViews(NSArray* views,
[CATransaction
setAnimationTimingFunction:TimingFunction(ios::material::CurveEaseInOut)];
[CATransaction setAnimationDuration:ios::material::kDuration5];
+ [CATransaction setCompletionBlock:^{
+ [[NSNotificationCenter defaultCenter]
+ postNotificationName:kMenuDidShowNotification
+ object:nil];
+ }];
AnimateInViews([toolsCell allButtons], 10, 0);
AnimateInViews(visibleCells, 0, -10);
[CATransaction commit];

Powered by Google App Engine
This is Rietveld 408576698