Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Side by Side Diff: ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.mm

Issue 2894513002: Adding tools menu responsiveness metric. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.h" 5 #import "ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.h"
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 8
9 #include "base/ios/ios_util.h" 9 #include "base/ios/ios_util.h"
10 #import "base/ios/weak_nsobject.h" 10 #import "base/ios/weak_nsobject.h"
11 #include "base/logging.h" 11 #include "base/logging.h"
12 #include "base/mac/objc_property_releaser.h" 12 #include "base/mac/objc_property_releaser.h"
13 #include "base/mac/scoped_nsobject.h" 13 #include "base/mac/scoped_nsobject.h"
14 #include "base/metrics/field_trial.h" 14 #include "base/metrics/field_trial.h"
15 #include "components/strings/grit/components_strings.h" 15 #include "components/strings/grit/components_strings.h"
16 #include "ios/chrome/browser/experimental_flags.h" 16 #include "ios/chrome/browser/experimental_flags.h"
17 #import "ios/chrome/browser/ui/animation_util.h" 17 #import "ios/chrome/browser/ui/animation_util.h"
18 #import "ios/chrome/browser/ui/commands/UIKit+ChromeExecuteCommand.h" 18 #import "ios/chrome/browser/ui/commands/UIKit+ChromeExecuteCommand.h"
19 #include "ios/chrome/browser/ui/commands/ios_command_ids.h" 19 #include "ios/chrome/browser/ui/commands/ios_command_ids.h"
20 #import "ios/chrome/browser/ui/reading_list/reading_list_menu_notification_deleg ate.h" 20 #import "ios/chrome/browser/ui/reading_list/reading_list_menu_notification_deleg ate.h"
21 #import "ios/chrome/browser/ui/reading_list/reading_list_menu_notifier.h" 21 #import "ios/chrome/browser/ui/reading_list/reading_list_menu_notifier.h"
22 #import "ios/chrome/browser/ui/toolbar/toolbar_controller.h"
22 #import "ios/chrome/browser/ui/tools_menu/reading_list_menu_view_item.h" 23 #import "ios/chrome/browser/ui/tools_menu/reading_list_menu_view_item.h"
23 #import "ios/chrome/browser/ui/tools_menu/tools_menu_constants.h" 24 #import "ios/chrome/browser/ui/tools_menu/tools_menu_constants.h"
24 #import "ios/chrome/browser/ui/tools_menu/tools_menu_model.h" 25 #import "ios/chrome/browser/ui/tools_menu/tools_menu_model.h"
25 #import "ios/chrome/browser/ui/tools_menu/tools_menu_view_item.h" 26 #import "ios/chrome/browser/ui/tools_menu/tools_menu_view_item.h"
26 #import "ios/chrome/browser/ui/tools_menu/tools_menu_view_tools_cell.h" 27 #import "ios/chrome/browser/ui/tools_menu/tools_menu_view_tools_cell.h"
27 #import "ios/chrome/browser/ui/tools_menu/tools_popup_controller.h" 28 #import "ios/chrome/browser/ui/tools_menu/tools_popup_controller.h"
28 #include "ios/chrome/browser/ui/ui_util.h" 29 #include "ios/chrome/browser/ui/ui_util.h"
29 #import "ios/chrome/browser/ui/uikit_ui_util.h" 30 #import "ios/chrome/browser/ui/uikit_ui_util.h"
30 #import "ios/chrome/common/material_timing.h" 31 #import "ios/chrome/common/material_timing.h"
31 #include "ios/chrome/grit/ios_strings.h" 32 #include "ios/chrome/grit/ios_strings.h"
(...skipping 395 matching lines...) Expand 10 before | Expand all | Expand 10 after
427 subarrayWithRange:NSMakeRange(1, [visibleCells count] - 1)]; 428 subarrayWithRange:NSMakeRange(1, [visibleCells count] - 1)];
428 } else { 429 } else {
429 toolsCell = nil; 430 toolsCell = nil;
430 } 431 }
431 } 432 }
432 433
433 [CATransaction begin]; 434 [CATransaction begin];
434 [CATransaction 435 [CATransaction
435 setAnimationTimingFunction:TimingFunction(ios::material::CurveEaseInOut)]; 436 setAnimationTimingFunction:TimingFunction(ios::material::CurveEaseInOut)];
436 [CATransaction setAnimationDuration:ios::material::kDuration5]; 437 [CATransaction setAnimationDuration:ios::material::kDuration5];
438 [CATransaction setCompletionBlock:^{
439 [[NSNotificationCenter defaultCenter]
440 postNotificationName:kMenuDidShowNotification
441 object:nil];
442 }];
437 AnimateInViews([toolsCell allButtons], 10, 0); 443 AnimateInViews([toolsCell allButtons], 10, 0);
438 AnimateInViews(visibleCells, 0, -10); 444 AnimateInViews(visibleCells, 0, -10);
439 [CATransaction commit]; 445 [CATransaction commit];
440 446
441 [[self readingListCell] 447 [[self readingListCell]
442 updateBadgeCount:_readingListMenuNotifier.get().readingListUnreadCount 448 updateBadgeCount:_readingListMenuNotifier.get().readingListUnreadCount
443 animated:YES]; 449 animated:YES];
444 [[self readingListCell] 450 [[self readingListCell]
445 updateSeenState:_readingListMenuNotifier.get().readingListUnseenItemsExist 451 updateSeenState:_readingListMenuNotifier.get().readingListUnseenItemsExist
446 animated:YES]; 452 animated:YES];
(...skipping 162 matching lines...) Expand 10 before | Expand all | Expand 10 after
609 615
610 - (void)unreadCountChanged:(NSInteger)unreadCount { 616 - (void)unreadCountChanged:(NSInteger)unreadCount {
611 [[self readingListCell] updateBadgeCount:unreadCount animated:YES]; 617 [[self readingListCell] updateBadgeCount:unreadCount animated:YES];
612 } 618 }
613 619
614 - (void)unseenStateChanged:(BOOL)unseenItemsExist { 620 - (void)unseenStateChanged:(BOOL)unseenItemsExist {
615 [[self readingListCell] updateSeenState:unseenItemsExist animated:YES]; 621 [[self readingListCell] updateSeenState:unseenItemsExist animated:YES];
616 } 622 }
617 623
618 @end 624 @end
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698