Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 2894483004: DevTools: install resizer on horizontal headers in Sources. (Closed)

Created:
3 years, 7 months ago by pfeldman
Modified:
3 years, 7 months ago
Reviewers:
alph, luoe
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: install resizer on horizontal headers in Sources. BUG=642921 Review-Url: https://codereview.chromium.org/2894483004 Cr-Commit-Position: refs/heads/master@{#474145} Committed: https://chromium.googlesource.com/chromium/src/+/41d3ae1f3a5267fbf65cef8fde127f50fbe4cd71

Patch Set 1 #

Patch Set 2 : same #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js View 1 2 chunks +9 lines, -0 lines 1 comment Download

Messages

Total messages: 14 (8 generated)
luoe
lgtm
3 years, 7 months ago (2017-05-22 18:00:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2894483004/40001
3 years, 7 months ago (2017-05-23 18:39:15 UTC) #5
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 7 months ago (2017-05-23 18:39:17 UTC) #7
alph
lgtm https://codereview.chromium.org/2894483004/diff/40001/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js File third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js (right): https://codereview.chromium.org/2894483004/diff/40001/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js#newcode1071 third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js:1071: this._splitWidget.installResizer(this._debugToolbar.element); Is it ok to call this multiple ...
3 years, 7 months ago (2017-05-23 21:23:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2894483004/40001
3 years, 7 months ago (2017-05-23 22:49:55 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-24 03:21:04 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/41d3ae1f3a5267fbf65cef8fde12...

Powered by Google App Engine
This is Rietveld 408576698