Fix behavior of clipboard commands when there is unfocused selection

Fix behavior of clipboard commands when there is unfocused selection

User-triggered clipboard commands should be disabled when selection
doesn't have focus. Hence, this patch checks whether selection has
focus in EnabledCopy/Cut/Paste.

However, this is a quirk that allows clipboard commands to run even
their enabled functions return false, so that clipboard events are
still fired regardless of the enabled state. To work with this quirk,
this patch also checks whether selection has focus in
Editor::Copy/Cut/Paste/PasteAsPlainText, and if not, stops the command.

BUG=722925
TEST=editing/pasteboard/pasteboard_with_unfocused_selection.html

Review-Url: https://codereview.chromium.org/2894473003
Cr-Commit-Position: refs/heads/master@{#472985}
Committed: https://chromium.googlesource.com/chromium/src/+/f8ff4f535ca35569ff840d9ffb71bb3e9e5d3ee1

[Xiaocheng, 2017-05-17 23:00:06]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 23:01:46]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2017-05-18 00:05:25]

Description was changed from

==========
Fix behavior of clipboard commands when there is unfocused selection

BUG=
==========

to

==========
Fix behavior of clipboard commands when there is unfocused selection

User-triggered clipboard commands should be disabled when selection
doesn't have focus. Hence, this patch checks whether selection has
focus in EnabledCopy/Cut/Paste.

However, this is a quirk that allows clipboard commands to run even
their enabled functions return false, so that clipboard events are
still fired regardless of the enabled state. To work with this quirk,
this patch also checks whether selection has focus in
Editor::Copy/Cut/Paste/PasteAsPlainText, and if not, stops the command.

BUG=
TEST=editing/pasteboard/pasteboard_with_unfocused_selection.html
==========

[Xiaocheng, 2017-05-18 00:06:11]

Description was changed from

==========
Fix behavior of clipboard commands when there is unfocused selection

User-triggered clipboard commands should be disabled when selection
doesn't have focus. Hence, this patch checks whether selection has
focus in EnabledCopy/Cut/Paste.

However, this is a quirk that allows clipboard commands to run even
their enabled functions return false, so that clipboard events are
still fired regardless of the enabled state. To work with this quirk,
this patch also checks whether selection has focus in
Editor::Copy/Cut/Paste/PasteAsPlainText, and if not, stops the command.

BUG=
TEST=editing/pasteboard/pasteboard_with_unfocused_selection.html
==========

to

==========
Fix behavior of clipboard commands when there is unfocused selection

User-triggered clipboard commands should be disabled when selection
doesn't have focus. Hence, this patch checks whether selection has
focus in EnabledCopy/Cut/Paste.

However, this is a quirk that allows clipboard commands to run even
their enabled functions return false, so that clipboard events are
still fired regardless of the enabled state. To work with this quirk,
this patch also checks whether selection has focus in
Editor::Copy/Cut/Paste/PasteAsPlainText, and if not, stops the command.

BUG=722925
TEST=editing/pasteboard/pasteboard_with_unfocused_selection.html
==========

[Xiaocheng, 2017-05-18 00:06:18]

xiaochengh@chromium.org changed reviewers:
+ yosin@chromium.org

[Xiaocheng, 2017-05-18 00:06:19]

PTAL.

[commit-bot: I haz the power, 2017-05-18 01:09:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 01:09:52]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yosin_UTC9, 2017-05-18 01:09:53]

The CQ bit was unchecked by yosin@chromium.org

[yosin_UTC9, 2017-05-18 01:12:37]

lgtm

This patch changes behavior of menu or keybinding case.
Document#execCommand() called by UI event handler is not affected.


Menu command is executed by:
- Editor::Command::Execute()
- Editor::Command::CreateCommand() w/ kCommandFromMenuOrKeyBinding,
- WebLocalFrameImpl::ExecuteCommand()

[yosin_UTC9, 2017-05-18 01:12:48]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-05-18 01:14:56]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 03:10:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 03:10:35]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Xiaocheng, 2017-05-18 03:22:43]

Whoops. Unit tests should also be modified...

[Xiaocheng, 2017-05-18 03:30:55]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[Xiaocheng, 2017-05-18 03:31:38]

xiaochengh@chromium.org changed reviewers:
+ tkent@chromium.org

[Xiaocheng, 2017-05-18 03:31:38]

+tkent for core/svg

[commit-bot: I haz the power, 2017-05-18 03:33:40]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 08:06:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 08:06:06]

Dry run: This issue passed the CQ dry run.

[tkent, 2017-05-18 23:38:00]

lgtm

[Xiaocheng, 2017-05-19 00:00:33]

The CQ bit was checked by xiaochengh@chromium.org

[Xiaocheng, 2017-05-19 00:00:33]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/2894473003/#ps40001
(title: "Fix UnsafeSVGAttributeSanitizationTest")

[commit-bot: I haz the power, 2017-05-19 00:03:50]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 00:12:18]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495152033428570,
"parent_rev": "344a463dc6925a89b86baabffa306cf569303e01", "commit_rev":
"f8ff4f535ca35569ff840d9ffb71bb3e9e5d3ee1"}

[commit-bot: I haz the power, 2017-05-19 00:12:35]

Description was changed from

==========
Fix behavior of clipboard commands when there is unfocused selection

User-triggered clipboard commands should be disabled when selection
doesn't have focus. Hence, this patch checks whether selection has
focus in EnabledCopy/Cut/Paste.

However, this is a quirk that allows clipboard commands to run even
their enabled functions return false, so that clipboard events are
still fired regardless of the enabled state. To work with this quirk,
this patch also checks whether selection has focus in
Editor::Copy/Cut/Paste/PasteAsPlainText, and if not, stops the command.

BUG=722925
TEST=editing/pasteboard/pasteboard_with_unfocused_selection.html
==========

to

==========
Fix behavior of clipboard commands when there is unfocused selection

User-triggered clipboard commands should be disabled when selection
doesn't have focus. Hence, this patch checks whether selection has
focus in EnabledCopy/Cut/Paste.

However, this is a quirk that allows clipboard commands to run even
their enabled functions return false, so that clipboard events are
still fired regardless of the enabled state. To work with this quirk,
this patch also checks whether selection has focus in
Editor::Copy/Cut/Paste/PasteAsPlainText, and if not, stops the command.

BUG=722925
TEST=editing/pasteboard/pasteboard_with_unfocused_selection.html

Review-Url: https://codereview.chromium.org/2894473003
Cr-Commit-Position: refs/heads/master@{#472985}
Committed:
https://chromium.googlesource.com/chromium/src/+/f8ff4f535ca35569ff840d9ffb71...
==========

[commit-bot: I haz the power, 2017-05-19 00:12:36]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f8ff4f535ca35569ff840d9ffb71...